HugoGresse / open-feedback

Open Feedback is an opened SaaS platform destined to organisers to gather feedback from users. OpenFeedback
https://openfeedback.io
GNU Affero General Public License v3.0
101 stars 16 forks source link

Add super admin to follow SaaS usage #1633

Closed HugoGresse closed 1 month ago

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [5761222](https://dashboard.gitguardian.com/workspace/1893/incidents/5761222?occurrence=161059420) | Triggered | Generic Password | 9f78098ccefaa18fbd51eca049ea2b5e4e41adef | cypress/fixtures/firebase-emulators-data/auth_export/accounts.json | [View secret](https://github.com/HugoGresse/open-feedback/commit/9f78098ccefaa18fbd51eca049ea2b5e4e41adef#diff-b35cc232ec601860754abeef2e011bcd2d1e59ccbf68227ad99c969b0d8a70caL11) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

cypress[bot] commented 1 month ago

2 flaky tests on run #2920 ↗︎

0 14 0 0 Flakiness 2

Details:

Add super admin to follow SaaS usage (#1633)
Project: open-feedback Commit: 5845aa45b1
Status: Passed Duration: 02:18 💡
Started: Jul 21, 2024 8:32 PM Ended: Jul 21, 2024 8:34 PM
Flakiness  feedback/talk.spec.js • 1 flaky test View Output
Test Artifacts
Single talk > Check that boolean vote does work with multiples votes as the same time as text votes Test Replay Screenshots
Flakiness  admin/organization.spec.js • 1 flaky test View Output
Test Artifacts
Test organization as owner role > Create a new organization, change voting form, langs, theme, and verify on project Test Replay Screenshots

Review all test suite changes for PR #1633 ↗︎