Added check for valid resubmission date

[christianlupus]

This checks if a date has already been set up or only the rule text. If only the rule text is set up, the date is autofilled with today.

[christianlupus]

I'll rebase it, please wait a few moments.

[christianlupus]

Tested on my testing environment, success.

As soon as either the resubmission date or rule field is not readable, a warning is issued in the logger and the resubmission is avoided.

[christianlupus]

@HugoHasenbein Do you prefer a merge based history or rebased commits?

[christianlupus]

As I'd like to get rid of this PR, I decided to go with rebasing. Seemed better suited.

This, in fact, should solve the following issue: When no date is provided, today is assumed as a default date. I have to be honest that I have not tested the latest version yet. I think it should work but I am unsure what variables are in fact not present. You might want to have a closer look at the changes.

[christianlupus]

@HugoHasenbein, dieser PR steht nun schon eine ganze Weile offen. Hätte ich es besser als Feature Request formulieren sollen oder ist die Funktionalität nicht gewünscht?

Ich wollte an der Stelle einfach die Arbeit minimieren, die notwendig ist.

Wie soll es denn hier nun weiter gehen?

[HugoHasenbein]

Lieber Christian,

macht es sinn, ein leeres Resubmission-Date Feld automatisch mit "heute" zu füllen?

Es gibt doch viele Tickets, die nicht wiedervorgelegt werden müssen.

Viele Grüße

Stephan

This, in fact, should solve the following issue: When no date is provided, today is assumed as a default date. I have to be honest that I have not tested the latest version yet. I think it should work but I am unsure what variables are in fact not present. You might want to have a closer look at the changes.

Am 11.05.2020 um 10:01 schrieb Christian notifications@github.com:

@HugoHasenbein https://github.com/HugoHasenbein, dieser PR steht nun schon eine ganze Weile offen. Hätte ich es besser als Feature Request formulieren sollen oder ist die Funktionalität nicht gewünscht?

Ich wollte an der Stelle einfach die Arbeit minimieren, die notwendig ist.

Wie soll es denn hier nun weiter gehen?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_auto_resubmission/pull/3#issuecomment-626539985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHM5FLQBS627T7KB23RQ6WEXANCNFSM4KIIBZ4A.

[christianlupus]

OK, the idea was the following: You have 4 cases in total. Both fields empty (no resubmission, ok), both fields filled (planned recurring resubmission, ok), and the case that either field is empty and the other given. Let's consider the different interesting cases:

For the case only a date is given (no rule), I suggest to have a one-time resubmission. The plugin removes the resubmission in case the date has passed. At the moment this results in a daily reminder without updating the date.

The last case (no date given but rule present), is most probably a user setting error. The user might simply have forgotten to set the date. In this case, my suggestion is to cover the error bu assuming today's date as a fallback (or even as a feature to reduce required user interaction).

Are you @HugoHasenbein ok with this analysis? Then I might get things straight once we agree on the desired behavior.

[christianlupus]

Ich schicke mal ein kurzes Ping, @HugoHasenbein.

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution

[HugoHasenbein]

good idea, thanks for the contribution