search

HugoHasenbein / redmine_project_themes

Redmine plugin for provides project specific themes
https://www.redmine.org/plugins/redmine_project_theme
GNU General Public License v2.0
7 stars 3 forks source link

Project page by theme #3

Closed CNPF closed 3 years ago

CNPF commented 4 years ago

The objectif is create a project page by theme. I try add a theme project filter. After with plugin additionnals https://www.redmine.org/plugins/additionals, i can add menu.

have you an idea to add filter on page redmine/projects? Thanks

HugoHasenbein commented 4 years ago

Dear CPNF (I'm sorry, I do not have another name from you)

I'm not quite sure, if I understand, what you are trying to accomplish.

Are you trying to filter projects by theme? If so, in which view are you trying to filter projects by theme?

Are you looking for a theme filter in the /projects view?

Best regards

Stephan

Am 07.01.2020 um 13:29 schrieb CNPF - SNDNI notifications@github.com:

The objectif is create a project page by theme. I try add a theme project filter. After with plugin additionnals https://www.redmine.org/plugins/additionals https://www.redmine.org/plugins/additionals, i can add menu.

have you an idea to add filter on page redmine/projects? Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRBZO5GDSU2YL24KZ63Q4RYULA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEPHRSA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRFND3YDFHMTL5H2GYDQ4RYULANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Sorry my English, My name is Richard,

  1. hide Project Menu
  2. add Menu (example Theme1) with first theme. This is page link listing project configured Theme1 3 . add Menu (example Theme2) with first theme. This is page link listing project configured Theme2 4 again...

image

Il try add filter in view project app/views/projects/index.html.erb. I think use filter but perhaps it's not fine.

HugoHasenbein commented 4 years ago

Dear Richard,

in principle, it is possible to filter projects by theme.

This would mean to add a button in the global configuration parameters section "Filter projects by theme".

This again would make it necessary to add a filter in the projects view to give this feature a meaningful sense, if the plugin is used alone (i.e. without the 'additionals' plugin.

Please see Mock-Screen.png as an example how it could look like.

Is it that, what you try to accomplish?

best regards

Stephan

Am 07.01.2020 um 14:07 schrieb CNPF - SNDNI notifications@github.com:

Sorry my English, My name is Richard,

hide Project Menu add Menu (example Theme1) with first theme. This is page link listing project configured Theme1 3 . add Menu (example Theme2) with first theme. This is page link listing project configured Theme2 4 again... https://user-images.githubusercontent.com/15978518/71897138-f627b500-3155-11ea-9043-6af236bbdd37.png Il try add filter in view project app/views/projects/index.html.erb. I think use filter but perhaps it's not fine.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRDNB556XDH3RUMPDHLQ4R5AJA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIIZPBY#issuecomment-571578247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHJKHGESEEQFZB2NLLQ4R5AJANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Dear Stephan Yes, in redmine 4.1.0, there is a new section in the project view. The section contain the filters. I not find how add a filter at the list. image Thanks Richard

HugoHasenbein commented 4 years ago

Dear Richard,

I have compiled a special version for you, which should run on redmine 3.4 - 4.1.

It will support a "Theme"-filter in the Projects index. Since I have not stress-tested it yet, it is not yet published.

If you are willing to try -please go ahead. If it works on your installation as well, then I will publish it. If you tell me your full name I will even credit you for your contribution of the French translation.

Best regards

Stephan

Am 07.01.2020 um 17:57 schrieb Richard L. - CNPF SDN notifications@github.com:

Dear Stephan Yes, in redmine 4.1.0, there is a new section in the project view. The section contain the filters. I not find how add a filter at the list. https://user-images.githubusercontent.com/15978518/71912963-c341e900-3176-11ea-9942-f5c994bd998a.png Thanks Richard

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRF7XTOTB6QGCUO7FETQ4SYA3A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJRJMI#issuecomment-571675825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHGSZIWRLCRSIEPD6TQ4SYA3ANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Hi stephane Thanks a lot, No problem to execute stress-test on my environment 4.0.0 and 4.1.0. Where can i download the special version? My name is Richard LEHAUT.
Best regards Richard

HugoHasenbein commented 4 years ago

Dear Richard,

I did attach it to my last email. Possibly it was not transmitted through github

Download it from my server:

https://redmine.humboldt-patent.com/redmine_project_themes.tgz https://redmine.humboldt-patent.com/redmine_project_themes.tgz

I have "hardcoded" Rails Version 5.1 for migration. I may need to add some dynamic migration depending on Rails version. Since you do need to migrate anymore, just replace the old version with this this release

Once you did test it, I will publish the release and credit you for translation

Best regards

Stephan

Am 08.01.2020 um 07:47 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Hi stephane Thanks a lot, No problem to execute stress-test on my environment 4.0.0 and 4.1.0. Where can i download the special version? My name is Richard LEHAUT. Best regards Richard

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRBOBU2BHG543EEGS4LQ4VZILA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEILLTEA#issuecomment-571914640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRCJVAONEQ3C2CGGOSLQ4VZILANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Hi I have a error in patched of query project. I did not manage to solve it. Sorry!

[ 2020-01-08 08:42:44.0323 30141/7ff574954700 age/Cor/App/Implementation.cpp:304 ]: Could not spawn process for application /opt/redmine/redmine-4.1.0: An error occurred while starting up the preloader. Error ID: f991edfc Error details saved to: /tmp/passenger-error-c8QDea.html Message from application: undefined method initialize_available_filters' for moduleRedmineProjectThemes::Patches::ProjectQueryPatch' Did you mean? initialize_clone (NameError) /opt/redmine/redmine-4.1.0/plugins/redmine_project_themes/lib/redmine_project_themes/patches/project_query_patch.rb:32:in `alias_method'

HugoHasenbein commented 4 years ago

Don't worry. I may have a different Rails Version

I have updated the file ProjectQueryPatch

Please, use the identical link, i have sent and try again.

Best regards and thank you for your help

Stephan

Am 08.01.2020 um 09:49 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Hi I have a error in patched of query project. I did not manage to solve it. Sorry!

[ 2020-01-08 08:42:44.0323 30141/7ff574954700 age/Cor/App/Implementation.cpp:304 ]: Could not spawn process for application /opt/redmine/redmine-4.1.0: An error occurred while starting up the preloader. Error ID: f991edfc Error details saved to: /tmp/passenger-error-c8QDea.html Message from application: undefined method initialize_available_filters' for module RedmineProjectThemes::Patches::ProjectQueryPatch' Did you mean? initialize_clone (NameError) /opt/redmine/redmine-4.1.0/plugins/redmine_project_themes/lib/redmine_project_themes/patches/project_query_patch.rb:32:in `alias_method'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRFJIEW3E2ME5XIV623Q4WHTBA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEILUGTY#issuecomment-571949903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRBGMON5T5BUULIECZLQ4WHTBANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

hi stephan This my first expérience of Ruby. :( The problem is the patch not included the classes og project_query

before 

  def self.included(base) # :nodoc:
     if Rails::VERSION::MAJOR >= 5
      base.send(:include, InstanceMethods)
      alias_method :initialize_available_filters_without_ui_themes, :initialize_available_filters
      alias_method :initialize_available_filters, :initialize_available_filters_with_ui_themes
      self.available_columns += [
         QueryColumn.new(:ui_theme, :sortable => "#{Project.table_name}.ui_theme", :groupable => Project.ui_theme_for_group_statement)
      ]

    end #if
  end #included

after

  def self.included(base) # :nodoc:
    if Rails::VERSION::MAJOR >= 5
      base.send(:include, InstanceMethods)
      base.class_eval do
         unloadable
         alias_method :initialize_available_filters_without_ui_themes, :initialize_available_filters
         alias_method :initialize_available_filters, :initialize_available_filters_with_ui_themes
         self.available_columns += [
            QueryColumn.new(:ui_theme, :sortable => "#{Project.table_name}.ui_theme", :groupable => Project.ui_theme_for_group_statement)
         ]
      end
    end #if
  end #included

Now I have this problem. Error ID: 483f865d Error details saved to: /tmp/passenger-error-v0RGyM.html Message from application: undefined method `ui_theme_for_group_statement' for # (NoMethodError)

I very difficult for me, but i try :)

best regards Richard

HugoHasenbein commented 4 years ago

Dear Richard,

I know where the problem is: the class method Project.ui_theme_for_group is not included in a self.class_eval block.

Again I have changed the plugin, this time in project_patch.rb

Now, it should work

Just use the identical link

best regards

Stephan

Am 08.01.2020 um 11:48 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

hi stephan This my first expérience of Ruby. :( The problem is the patch not included the classes og project_query

before

def self.included(base) # :nodoc: if Rails::VERSION::MAJOR >= 5 base.send(:include, InstanceMethods) alias_method :initialize_available_filters_without_ui_themes, :initialize_available_filters alias_method :initialize_available_filters, :initialize_available_filters_with_ui_themes self.available_columns += [ QueryColumn.new(:ui_theme, :sortable => "#{Project.table_name}.ui_theme", :groupable => Project.ui_theme_for_group_statement) ]

end #if

end #included after

def self.included(base) # :nodoc: if Rails::VERSION::MAJOR >= 5 base.send(:include, InstanceMethods) base.class_eval do unloadable alias_method :initialize_available_filters_without_ui_themes, :initialize_available_filters alias_method :initialize_available_filters, :initialize_available_filters_with_ui_themes self.available_columns += [ QueryColumn.new(:ui_theme, :sortable => "#{Project.table_name}.ui_theme", :groupable => Project.ui_theme_for_group_statement) ] end end #if end #included Now I have this problem. Error ID: 483f865d Error details saved to: /tmp/passenger-error-v0RGyM.html Message from application: undefined method `ui_theme_for_group_statement' for #Class:0x0055c5103a3ce0 (NoMethodError)

I very difficult for me, but i try :)

best regards Richard

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRETW527CFBMFRX4H7DQ4WVPNA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIL7FJA#issuecomment-571994788, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRECVYVCEF2FPLHYER3Q4WVPNANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Hi, Excuse me, i doesn't sucess. In projects_helper_patch.rb, I replace function alias_method_chain by alias_method :project_settings_tabs_without_project_themes_setting, :project_settings_tabs alias_method :project_settings_tabs, :project_settings_tabs_with_project_themes_setting

I have to problem 1. When execute a filter here is the log apache

App 6845 stderr: Started GET "/redmine/projects?utf8=%E2%9C%93&set_filter=1&sort=&f%5B%5D=status&op%5Bstatus%5D=%3D&v%5Bstatus%5D%5B%5D=1&f%5B%5D=Th%C3%A8me&op%5BTh%C3%A8me%5D=%3D&v%5BTh%C3%A8me%5D%5B%5D=classic&f%5B%5D=&display_type=board&c%5B%5D=name&c%5B%5D=identifier&c%5B%5D=short_description&group_by=" for 90.108.47.151 at 2020-01-08 12:50:34 +0000 App 6845 stderr: Processing by ProjectsController#index as HTML App 6845 stderr: Parameters: {"utf8"=>"✓", "set_filter"=>"1", "sort"=>"", "f"=>["status", "Thème", ""], "op"=>{"status"=>"=", "Thème"=>"="}, "v"=>{"status"=>["1"], "Thème"=>["classic"]}, "display_type"=>"board", "c"=>["name", "identifier", "short_description"], "group_by"=>""} App 6845 stderr: Current user: richard.lehaut (id=11) App 6845 stderr: Completed 500 Internal Server Error in 10ms (ActiveRecord: 3.2ms) App 6845 stderr: App 6845 stderr: ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR: column projects.thème does not exist App 6845 stderr: LINE 1: ...status <> 9) AND ((projects.status IN ('1')) AND (projects.T... App 6845 stderr: ^ App 6845 stderr: HINT: Perhaps you meant to reference the column "projects.name". App 6845 stderr: : SELECT "projects".* FROM "projects" WHERE (projects.status <> 9) AND ((projects.status IN ('1')) AND (projects.Thème IN ('classic'))) ORDER BY projects.lft ASC): App 6845 stderr:

I don't find the config of field name. In postgres, the fieldname is ui_theme.

  1. I find a problem of encoding in fr.yml file. the french and their accents ;)

  2. when go to project with theme is configured, it not applicated. I don't have log message http://35.180.27.5/redmine/projects/test/settings/project_themes_settings, the name of theme isn't choose in theme's list.

Thank you for your patience Richard

HugoHasenbein commented 4 years ago

Dear Richard,

I must look into the redmine 4.1 implementation of query.rb. I have done some hacks to be able to group projects by its real theme name, but I forgot, that French love accents.

Currently, I have do do some work. Ifyou don't mind, I will send you another version, which is compatible with redmine 4.1 - if you do have some more patience with me and possibly a few more versions

Best regards

Stephan

Am 08.01.2020 um 13:58 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Hi, Excuse me, i doesn't sucess. In projects_helper_patch.rb, I replace function alias_method_chain by alias_method :project_settings_tabs_without_project_themes_setting, :project_settings_tabs alias_method :project_settings_tabs, :project_settings_tabs_with_project_themes_setting

I have to problem

  1. When execute a filter here is the log apache

App 6845 stderr: Started GET "/redmine/projects?utf8=%E2%9C%93&set_filter=1&sort=&f%5B%5D=status&op%5Bstatus%5D=%3D&v%5Bstatus%5D%5B%5D=1&f%5B%5D=Th%C3%A8me&op%5BTh%C3%A8me%5D=%3D&v%5BTh%C3%A8me%5D%5B%5D=classic&f%5B%5D=&display_type=board&c%5B%5D=name&c%5B%5D=identifier&c%5B%5D=short_description&group_by=" for 90.108.47.151 at 2020-01-08 12:50:34 +0000 App 6845 stderr: Processing by ProjectsController#index as HTML App 6845 stderr: Parameters: {"utf8"=>"✓", "set_filter"=>"1", "sort"=>"", "f"=>["status", "Thème", ""], "op"=>{"status"=>"=", "Thème"=>"="}, "v"=>{"status"=>["1"], "Thème"=>["classic"]}, "display_type"=>"board", "c"=>["name", "identifier", "short_description"], "group_by"=>""} App 6845 stderr: Current user: richard.lehaut (id=11) App 6845 stderr: Completed 500 Internal Server Error in 10ms (ActiveRecord: 3.2ms) App 6845 stderr: App 6845 stderr: ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR: column projects.thème does not exist App 6845 stderr: LINE 1: ...status <> 9) AND ((projects.status IN ('1')) AND (projects.T... App 6845 stderr: ^ App 6845 stderr: HINT: Perhaps you meant to reference the column "projects.name". App 6845 stderr: : SELECT "projects".* FROM "projects" WHERE (projects.status <> 9) AND ((projects.status IN ('1')) AND (projects.Thème IN ('classic'))) ORDER BY projects.lft ASC): App 6845 stderr:

I don't find the config of field name.

I find a problem of encoding in fr.yml file. the french and their accents ;)

when go to project with theme is configured, it not applicated. I don't have log message

Thank you for your patience Richard

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRFFLAI44BQI5CUIJ5DQ4XEXBA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIMJK2A#issuecomment-572036456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRDLSVJZSGPH564SNELQ4XEXBANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Dear Stephan,

Not so simple indeed. I need to complete my Redmine setup before the end of the month. I am Project Manager and do no development on Ruby. So I have time to wait for another version.

I will continue this week. If I can resolve the problem, I will contact you via Git.

Thank you so much

CNPF commented 4 years ago

A paused and a coffea, it's better. I modified /patches/project_query_patch.rb and theme filter execute with sucess def initialize_available_filters_with_ui_themes initialize_available_filters_without_ui_themes add_available_filter("ui_theme", :type => :list, :values => Redmine::Themes.themes.map{|t| [t.name, t.id]} ) end #def

Now, i seach solution of this problem : when a project with theme is configured, it not applicated.

HugoHasenbein commented 4 years ago

I found the same error, sorry for that. I will be back in a few minutes

Am 08.01.2020 um 16:50 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

A paused and a coffea, it's better. I modified /patches/project_query_patch.rb and theme filter execute with sucess def initialize_available_filters_with_ui_themes initialize_available_filters_without_ui_themes add_available_filter("ui_theme", :type => :list, :values => Redmine::Themes.themes.map{|t| [t.name, t.id]} ) end #def

Now, i seach solution of this problem : when a project with theme is configured, it not applicated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDREVVQKZ6QEZHKLPPPTQ4XY4RA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINANMQ#issuecomment-572130994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHE7XLN7LSW4EHNFFDQ4XY4RANCNFSM4KDYTTRQ.

HugoHasenbein commented 4 years ago

same here , fresh coffee: working and tested release on GitHub (fresh redmine 4.1.0, ruby 2.4.0, Rails 5.2.4.1 release) did you notice, you can group projects in list view by theme as well?

Am 08.01.2020 um 16:50 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

A paused and a coffea, it's better. I modified /patches/project_query_patch.rb and theme filter execute with sucess def initialize_available_filters_with_ui_themes initialize_available_filters_without_ui_themes add_available_filter("ui_theme", :type => :list, :values => Redmine::Themes.themes.map{|t| [t.name, t.id]} ) end #def

Now, i seach solution of this problem : when a project with theme is configured, it not applicated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDREVVQKZ6QEZHKLPPPTQ4XY4RA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINANMQ#issuecomment-572130994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHE7XLN7LSW4EHNFFDQ4XY4RANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

exactly, It's good. I write my first module for insert two links in top menu. ("I'm happy":) I reinstall since Github because the switch of theme not working here. I will be back in a few minutes

CNPF commented 4 years ago

The switch of theme not working here. Not Working. On config page of project theme, the list isn't initialize. I think, the problem is here. :(

I had saved my server before the new version. this had fine. I will look tomorow

Environment: Redmine version 4.1.0.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux-gnu] Rails version 5.2.4.1 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Git 2.11.0 Filesystem
Redmine plugins: redmine_agile 1.5.1 redmine_attachment_categories 1.0.3 redmine_checklists 3.1.16 redmine_image_clipboard_paste 3.3.0 redmine_issue_dynamic_edit 0.6.9 redmine_issues_tree 0.0.13 redmine_link 0.1.0 redmine_project_themes 1.0.3

CNPF commented 4 years ago

Unsolved problem, I tried -upgrade ruby -uninstall another plugin -comparing old and new version

I observed, when load config page of theme project :

I don't know where search !! :( I hope you can help me. Best regards.

HugoHasenbein commented 4 years ago

Dear Richard,

I'm not sure, if I got it right: "

The link to stylesheet isn't intialized The browser does not load the style sheet?

I assume, you have installed the themes under public/themes I also assume, you have configured Administration->Configuration->"General"-TAb->Hostname

With respect to the double #edit_project_132 - there must be another plugin messing this up

redmine_project_themes only uses one id: #help_ui_theme

I need more info to help

best regards

Stephan

Am 09.01.2020 um 14:14 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Unsolved problem, I tried -upgrade ruby -uninstall another plugin -comparing old and new version

I observed, when load config page of theme project :

The link to stylesheet isn't intialized

  • The option of theme project isn't selected Classic Classic there is a error mess in the console. [DOM] Found 2 elements with non-unique id #edit_project_132 (old and new version) I don't know where search !! :( I hope you can help me. Best regards.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRFERXPRU5GS7JAKNALQ44PL5A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIQIB5A#issuecomment-572555508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRBTSXCRAIFTUIJKUBLQ44PL5ANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Dear Stephan

Thanks for your help. This morning I create au new server.

Apply this path https://www.redmine.org/issues/32223#note-1 My version ruby is 2.3.4, is it a problem?

Environment: Redmine version 4.1.0.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux-gnu] Rails version 5.2.4.1 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Git 2.11.0 Filesystem
Redmine plugins: redmine_project_themes 1.0.3

bundle list Gems included by the bundle:

what do you need as informations? Sorry for the inconvenience Best Regards Richard

HugoHasenbein commented 4 years ago

all sounds perfect.

but what did you mean by "

The link to stylesheet isn't intialized

Am 10.01.2020 um 14:00 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Dear Stephan

Thanks for your help. This morning I create au new server.

Apply this path https://www.redmine.org/issues/32223#note-1 https://www.redmine.org/issues/32223#note-1 My version ruby is 2.3.4, is it a problem?

Environment: Redmine version 4.1.0.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux-gnu] Rails version 5.2.4.1 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Git 2.11.0 Filesystem Redmine plugins: redmine_project_themes 1.0.3

bundle list Gems included by the bundle:

actioncable (5.2.4.1) actionmailer (5.2.4.1) actionpack (5.2.4.1) actionpack-xml_parser (2.0.1) actionview (5.2.4.1) activejob (5.2.4.1) activemodel (5.2.4.1) activerecord (5.2.4.1) activestorage (5.2.4.1) activesupport (5.2.4.1) addressable (2.7.0) arel (9.0.0) builder (3.2.4) bundler (1.13.6) concurrent-ruby (1.1.5) crass (1.0.5) css_parser (1.7.1) csv (3.1.2) erubi (1.9.0) globalid (0.4.2) htmlentities (4.3.4) i18n (1.6.0) loofah (2.4.0) mail (2.7.1) marcel (0.3.3) method_source (0.9.2) mimemagic (0.3.3) mini_magick (4.9.5) mini_mime (1.0.2) mini_portile2 (2.4.0) minitest (5.13.0) net-ldap (0.16.2) nio4r (2.5.2) nokogiri (1.10.7) pg (1.1.4) public_suffix (4.0.3) rack (2.0.8) rack-openid (1.4.2) rack-test (1.1.0) rails (5.2.4.1) rails-dom-testing (2.0.3) rails-html-sanitizer (1.3.0) railties (5.2.4.1) rake (13.0.1) rbpdf (1.20.1) rbpdf-font (1.19.1) redcarpet (3.5.0) request_store (1.4.1) roadie (3.5.1) roadie-rails (1.3.0) rouge (3.12.0) ruby-openid (2.9.2) sprockets (3.7.2) sprockets-rails (3.2.1) thor (1.0.1) thread_safe (0.3.6) tzinfo (1.2.6) websocket-driver (0.7.1) websocket-extensions (0.1.4) what do you need as informations? Sorry for the inconvenience Best Regards Richard

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRH5LCVJLK2PQ2HCHMTQ5BWO3A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIT26EA#issuecomment-573026064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRAJP2MXO3TKNDGEY5LQ5BWO3ANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

When I charge a page of project with theme is configure, in head part of html page, I don't have

...link rel="stylesheet" media="all" href="/redmine/themes/classic/stylesheets/application.css?1576844384"..

I captured many informations. Sans titre

CNPF commented 4 years ago

I uninstalled the plugin and I've error. I try a show instance 4.1.0, and not migrate my 4.0.0 version Capture

HugoHasenbein commented 4 years ago

Dear Richard,

I am currently solving the issue. Just hang on

Am 10.01.2020 um 15:52 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

I uninstalled the plugin and I've error. I try a show instance 4.1.0, and not migrate my 4.0.0 version https://user-images.githubusercontent.com/15978518/72161772-02fc1100-33c1-11ea-9a49-28a3ea646297.PNG — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRHDAHSMPWMMJTXXFFDQ5CDRTA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIUEUZY#issuecomment-573065831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRF7PHIDIBWNHYG4CC3Q5CDRTANCNFSM4KDYTTRQ.

HugoHasenbein commented 4 years ago

Dear Richard,

redmine 4's feature to list projects was a challenge. Themes are not dependants of ActiveRecord::Base, thus grouping Projects by Themes was a bit tricky.

I have added some more Rails 5 functionality, such as Model.prepend(function) instead of alias_method_chain. To eliminate side effects with other plugins I have changed the choose Project Theme dialogue a bit.

It works on my installation.

Best regards

Stephan

Am 10.01.2020 um 15:52 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

I uninstalled the plugin and I've error. I try a show instance 4.1.0, and not migrate my 4.0.0 version https://user-images.githubusercontent.com/15978518/72161772-02fc1100-33c1-11ea-9a49-28a3ea646297.PNG — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRHDAHSMPWMMJTXXFFDQ5CDRTA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIUEUZY#issuecomment-573065831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRF7PHIDIBWNHYG4CC3Q5CDRTANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

With new version, I got a probleme oh method ui_theme. I resolved him with this patch.

diff --git a/lib/redmine_project_themes/patches/redmine_theme_patch.rb b/lib/redmine_project_themes/patches/redmine_theme_patch.rb index d225c6a..eae5fdc 100644 --- a/lib/redmine_project_themes/patches/redmine_theme_patch.rb +++ b/lib/redmine_project_themes/patches/redmine_theme_patch.rb @@ -31,7 +31,7 @@ module RedmineProjectThemes

'- @current_theme = (@project && @project.module_enabled?(:redmine_project_themes) && @project.ui_theme.present?) ? Redmine::Themes.theme(@project.ui_theme) : Redmine::Themes.theme(Setting.ui_theme) '+@current_theme = (@project && @project.module_enabled?(:redmine_project_themes) && @project.theme_id.present?) ? Redmine::Themes.theme(@project.theme_id) : Redmine::Themes.theme(Setting.ui_theme) end

The plungin is correct. Now, I'll continue tests. Thanks a lot.

I'll send a patch of fr.yml, to correct accents problems.

HugoHasenbein commented 4 years ago

Dear Richard,

you're running an obsolete version. Please check github.

This plugin was extremely tricky to support grouping in the projects page, therefore, I had to completely revamp the code.

Best regards

Stephan

Am 12.01.2020 um 10:09 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

With new version, I got a probleme oh method ui_theme. I resolved him with this patch.

diff --git a/lib/redmine_project_themes/patches/redmine_theme_patch.rb b/lib/redmine_project_themes/patches/redmine_theme_patch.rb index d225c6a..eae5fdc 100644 --- a/lib/redmine_project_themes/patches/redmine_theme_patch.rb +++ b/lib/redmine_project_themes/patches/redmine_theme_patch.rb @@ -31,7 +31,7 @@ module RedmineProjectThemes

     unless (instance_variable_defined?(:@current_theme) && instance_variable_defined?(:@current_project_for_theme) && @current_project_for_theme == @project )
       @current_project_for_theme = @project
     @current_theme = (@project && @project.module_enabled?(:redmine_project_themes) && @project.ui_theme.present?) ? Redmine::Themes.theme(@project.ui_theme) : Redmine::Themes.theme(Setting.ui_theme)
     @current_theme = (@project && @project.module_enabled?(:redmine_project_themes) && @project.theme_id.present?) ? Redmine::Themes.theme(@project.theme_id) : Redmine::Themes.theme(Setting.ui_theme)
   end

   @current_theme

The plungin is correct. Now, I'll continue tests. Thanks a lot.

I'll send a patch of fr.yml, to correct accents problems.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRG3YPILXUJHZ4H4EA3Q5LM3JA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWVHEI#issuecomment-573395857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRHG3VNCVYNJBCLZO6TQ5LM3JANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Hi Stephan, I donwload plugin with git clone https://github.com/HugoHasenbein/redmine_project_themes.git

I'll tested again on another server. I will be back in a few minutes

CNPF commented 4 years ago

Hi fr.yml.txt

I confirme errror an patch

Environment: Redmine version 4.1.0.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux-gnu] AND 2.4.0 Rails version 5.2.4.1 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Git 2.11.0 Filesystem
Redmine plugins: redmine_project_themes 1.1.0

HugoHasenbein commented 4 years ago

Does it work now?

Am 12.01.2020 um 10:57 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Hi fr.yml.txt https://github.com/HugoHasenbein/redmine_project_themes/files/4050482/fr.yml.txt I confirme errror an patch

Environment: Redmine version 4.1.0.stable Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux-gnu] AND 2.4.0 Rails version 5.2.4.1 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Git 2.11.0 Filesystem Redmine plugins: redmine_project_themes 1.1.0

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRAE4IKHZULZUZNQFFLQ5LSQ7A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWV77A#issuecomment-573399036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRBEJVSPYD5ZYAAH3A3Q5LSQ7ANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

YEs, I am in the process of installing the other plugins. For now, this plugin works.

HugoHasenbein commented 4 years ago

Great!. This was a tough one

Am 12.01.2020 um 11:06 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

YEs, I am in the process of installing the other plugins. For now, this plugin works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRGKXQ3MGIRN2PBHXVLQ5LTQ7A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWWEGY#issuecomment-573399579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRBRWIKQZDE4W54VFZTQ5LTQ7ANCNFSM4KDYTTRQ.

HugoHasenbein commented 4 years ago

Great!. This was a tough one

Am 12.01.2020 um 11:06 schrieb Richard LEHAUT - CNPF SDN <notifications@github.com mailto:notifications@github.com>:

YEs, I am in the process of installing the other plugins. For now, this plugin works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRGKXQ3MGIRN2PBHXVLQ5LTQ7A5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWWEGY#issuecomment-573399579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRBRWIKQZDE4W54VFZTQ5LTQ7ANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Great!. This was a tough one My new config redmine is ready. A question, When use filter theme, would it be difficult to charge this thème? An idea, how to do? I try develop this fonctionnality

CNPF commented 4 years ago

Happy Use plugin https://github.com/martin-denizet/redmine_custom_js to execute this code.

$(function(){ $.urlParam = function(name){ var results = new RegExp('[\?&]' + name + '=([^&#]*)').exec(window.location.href); return results[1] || 0; } var result = $.urlParam('query_id') if (result == 31) { $("head").append( $(document.createElement("link")).attr({rel:"stylesheet", type:"text/css", href:"/redmine/themes/projet/stylesheets/application.css?1578826828"}) ); console.log("Theme_projet"); } if (result == 30) { $("head").append( $(document.createElement("link")).attr({rel:"stylesheet", type:"text/css", href:"/redmine/themes/ticket/stylesheets/application.css?1578826828"}) ); console.log("Theme_ticket"); } });

HugoHasenbein commented 4 years ago

The filter term is governed by

field_theme: "Thème"

in fr.yml

Maybe the old fr.yml ist present in your configuration?

Else, your browser my be set to another locale.

If all fails, then use "Thèeme" in fr.yml

Am 12.01.2020 um 17:31 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Great!. This was a tough one My new config redmine is ready. A question, When use filter theme, would it be difficult to charge this thème? An idea, how to do? I try develop this fonctionnality

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRCRTIOC2ZPE6WA4RFTQ5NAXDA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW6F5Y#issuecomment-573432567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRFRRXJ3LBUVGKCNWG3Q5NAXDANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Sorry, my english is very bad. The plugin work fine. I add a "add-on". When filter projects with theme, i want to charge this theme. Look Jquery code. Jquery is more easy for me. ;)

HugoHasenbein commented 4 years ago

What do you mean by "charge"? Do you want to collect money from a user / customer when selecting the theme (engl. to charge - the act of demanding payment for a service)

Am 12.01.2020 um 17:59 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Sorry, my english is very bad. The plugin work fine. I add a "add-on". When filter projects with theme, i want to charge this theme. Look Jquery code. Jquery is more easy for me. ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRFQZVHT6WV56374WWLQ5NEARA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW62CA#issuecomment-573435144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDREAO2G3MRJQQBMGWN3Q5NEARANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Charge=use or apply this theme. i successed my goal with code jquery

HugoHasenbein commented 4 years ago

For that you could modify app/views/common/layouts/base.html.erb

and add a marker around

<%= heads_for_theme %>

like

<%= heads_for_theme %>

or any other tag, which is allowed in a html head section to mark the begin and the end of the theme.

Then, when you use the filter you can add an event handler to the filter and replace the heads_for_theme section.

May I ask you about the actual use case? For what purposes are you using the project theme setting?

Best regards

Stephan

Am 12.01.2020 um 18:34 schrieb Richard LEHAUT - CNPF SDN notifications@github.com:

Charge=use or apply this theme. i successed my goal with code jquery

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRF7Y2ZN5RGCZNQFCWDQ5NIBHA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW7SRA#issuecomment-573438276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRAB4IX6UYB3HMTSHMLQ5NIBHANCNFSM4KDYTTRQ.

CNPF commented 4 years ago

Hi Stephan, Thanks you for ideas. For what purposes are you using the project theme setting? we use redmine as a projects management tool and a support ticket system. for users, I want to distinct them Best regards Richard

nassim-centrimex commented 4 years ago

Hello

For that you could modify app/views/common/layouts/base.html.erb and add a marker around <%= heads_for_theme %> like <%= heads_for_theme %> or any other tag, which is allowed in a html head section to mark the begin and the end of the theme. Then, when you use the filter you can add an event handler to the filter and replace the heads_for_theme section. May I ask you about the actual use case? For what purposes are you using the project theme setting? Best regards Stephan … Am 12.01.2020 um 18:34 schrieb Richard LEHAUT - CNPF SDN @.***>: Charge=use or apply this theme. i successed my goal with code jquery — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AJWRDRF7Y2ZN5RGCZNQFCWDQ5NIBHA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW7SRA#issuecomment-573438276>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRAB4IX6UYB3HMTSHMLQ5NIBHANCNFSM4KDYTTRQ.

Hello I have this problem

ActionView::Template::Error (undefined method `ui_theme' for # Did you mean? theme): 8: 9: 10: <%= csrf_meta_tag %> 11: <%= favicon %> 12: <%= stylesheet_link_tag 'jquery/jquery-ui-1.11.0', 'tribute-3.7.3', 'application', 'responsive', :media => 'all' %> 13: <%= stylesheet_link_tag 'rtl', :media => 'all' if l(:direction) == 'rtl' %> 14: <%= javascript_heads %>

plugins/redmine_project_themes/lib/redmine_project_themes/patches/redmine_theme_patch.rb:34:in current_theme' app/helpers/application_helper.rb:1612:infavicon_path' app/helpers/application_helper.rb:1607:in favicon' app/views/layouts/base.html.erb:11:in_app_views_layouts_base_html_erb__143167068_88507680' lib/redmine/sudo_mode.rb:65:in `sudo_mode'

HugoHasenbein commented 4 years ago

Dear Nassim,

have you migrated the plugin? It seems, there is no ui_theme field in the projects table

bundle exec rake redmine:plugins:migrate RAILS_ENV=production NAME=redmine_project_themes

Best regards

Stephan

Am 16.09.2020 um 11:06 schrieb nassim-centrimex notifications@github.com:

Hello

For that you could modify app/views/common/layouts/base.html.erb and add a marker around <%= heads_for_theme %> like <%= heads_for_theme %> or any other tag, which is allowed in a html head section to mark the begin and the end of the theme. Then, when you use the filter you can add an event handler to the filter and replace the heads_for_theme section. May I ask you about the actual use case? For what purposes are you using the project theme setting? Best regards Stephan … <x-msg://18/#> Am 12.01.2020 um 18:34 schrieb Richard LEHAUT - CNPF SDN @.***>: Charge=use or apply this theme. i successed my goal with code jquery — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 https://github.com/HugoHasenbein/redmine_project_themes/issues/3?email_source=notifications&email_token=AJWRDRF7Y2ZN5RGCZNQFCWDQ5NIBHA5CNFSM4KDYTTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW7SRA#issuecomment-573438276>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRAB4IX6UYB3HMTSHMLQ5NIBHANCNFSM4KDYTTRQ https://github.com/notifications/unsubscribe-auth/AJWRDRAB4IX6UYB3HMTSHMLQ5NIBHANCNFSM4KDYTTRQ.

Hello I have this problem

ActionView::Template::Error (undefined method `ui_theme' for #Project:0x000000000c6a2320 Did you mean? theme): 8: 9: 10: <%= csrf_meta_tag %> 11: <%= favicon %> 12: <%= stylesheet_link_tag 'jquery/jquery-ui-1.11.0', 'tribute-3.7.3', 'application', 'responsive', :media => 'all' %> 13: <%= stylesheet_link_tag 'rtl', :media => 'all' if l(:direction) == 'rtl' %> 14: <%= javascript_heads %>

plugins/redmine_project_themes/lib/redmine_project_themes/patches/redmine_theme_patch.rb:34:in current_theme' app/helpers/application_helper.rb:1612:in favicon_path' app/helpers/application_helper.rb:1607:in favicon' app/views/layouts/base.html.erb:11:in _app_views_layouts_base_html_erb__143167068_88507680' lib/redmine/sudo_mode.rb:65:in `sudo_mode'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HugoHasenbein/redmine_project_themes/issues/3#issuecomment-693276406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRDRFQJOAD5CLNNKCS4R3SGB5YBANCNFSM4KDYTTRQ.

nassim-centrimex commented 4 years ago

image