search

Hugobros3 / chunkstories

Somewhat fancy blocky game engine written in Kotlin
http://chunkstories.xyz
Other
222 stars 10 forks source link

Add tests for xyz.chunkstories.util.math.HeightmapMesher.java #10

Closed sudo-jaa closed 5 years ago

sudo-jaa commented 5 years ago

Hi,

I've analysed your code base and noticed that xyz.chunkstories.util.math.HeightmapMesher is not fully tested.

I've written some tests for the functions in this class with the help of Diffblue Cover.

Hopefully these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.

Hugobros3 commented 5 years ago

This PR adds nothing but cruft to the codebase, not only is HeightmapMesher unused as things stands ( and thus deleting it outright would be the better move, but I'm saving it for later use ), but the proposed test class looks very autogenerated and doesn't capture the intended behavior of the class at all, it uses it in a random way that makes no sense. Here's a hint: The point of this class is to perform greedy meshing on a textured heightmap. Greedy meshing can't possibly do anything if you feed it garbage data.

I'm not really interested in pull requests for marketing purposes, this was clearly made with no particular knowledge or interest in the project, as evidenced by the absolute lack of context provided and generic PR message. I would rather not be bothered by these sort of "contributions" anymore.