search

Huh / collar

Utilities for exploring telemetry data
Other
7 stars 9 forks source link

Added functions to download data from Vectronics and ATS #23

Closed foresthayes closed 5 years ago

foresthayes commented 5 years ago

I have added functions for Vectronics and ATS collar data downloads - please review these and share your thoughts! I used the cllr prefix for consistency since that discussion has not been resolved yet.

A couple points for discussion:

  1. Do we want to differentiate between functions that web scrape vs make API calls? (see function names)
  2. I'm not sure if it is possible to download a subset of the data from ATS through web scraping but it would be nice if that could be added for consistency. Alternatively we might consider building in filter functionality after downloading the data.
  3. In the Vectronics function the start_date call does not work at this point in time.
  4. Thoughts on progress bars and messages? I added some to the Vectronics function that I rather like. For reference, my data set takes ~1 minute to download and process.
Huh commented 5 years ago

Good work Forest! I think I am of the opinion, today at least, that methods and classes are less useful for the download functions and we should establish classes as the output/return of these functions. I think S3 is appropriate and we can move forward with what you have developed.

Thanks for your contributions.

Josh