Huh / collar

Utilities for exploring telemetry data
Other
6 stars 9 forks source link

Quoted or unquoted arguments for functions? #43

Open foresthayes opened 5 years ago

foresthayes commented 5 years ago

I think this topic merits further discussion.

In principle I like the idea of unquoted arguments, however it seems to add a substantial amount of code to every function and greatly increases complexity in some cases. As we are increasing the scope of the package is this something worth continuing? For my part I am still struggling to predict how/when quosures will work and having difficulty getting them to work in more complex functions.

If we do keep with unquoted arguments, would it be possible to create an internal function that does much of heavy lifting as opposed to repeating code in each function?

Huh commented 5 years ago

I will look at the latest rlang documentation to see if there is any guidance or anything related to your question. I agree it is a bit onerous, but if I don't have to hit " twice for every argument I will be a happier user and when using dplyr I hate switching back and forth trying to remember what packages use it and which don't. I will search through some packages and see if I can't come up with some nice structures.

Thanks