search

Huh / collar

Utilities for exploring telemetry data
Other
6 stars 9 forks source link

Develop #85

Closed Huh closed 2 months ago

Huh commented 2 months ago

@ericnewkirk I updated the package to pass CMD checks. This included replacing select statements that relied on external vectors, replacing purrr::when with switch, and removing tests and examples that required a login. Functions influenced by these changes can be viewed in the diff. Please review and make any necessary tweaks.

ericnewkirk commented 2 months ago

@Huh sorry just saw the review request. On it tomorrow. Bummer that some of the demo accounts have been disabled, I don't really have any bright ideas on how to build tests without them. And the purrr::when thing is a killer.

ericnewkirk commented 2 months ago

Looks great. May be able to add functional examples/test/vignette for track tag next week, but I think it makes sense to merge this for now. One note from rcmd check about having a lot of packages in imports.