search

HullSeals / HalpyBOT

The Hull Seals IRC Utility bot, built with Pydle
GNU General Public License v3.0
7 stars 3 forks source link

Clean up announcer.py EDSM logic #119

Closed Rixxan closed 1 year ago

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:27

With the recent improvements to the EDSM lookups on incoming cases, the logic and processing of the systems has become messy and inefficient. This really should be cleaned up so that return values don't exist in multiple places and there is a more clear set of steps to it.

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:28

marked this issue as related to #73

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:28

marked this issue as related to #115

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:28

marked this issue as related to #108

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:33

removed the relation with #108

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:33

marked this issue as related to #108

Rixxan commented 2 years ago

In GitLab by @stuntphish on Dec 27, 2021, 13:51

Actually not nearly as much of a mess as I thought. Doesn't actually need any work tidying it up. Well done seals o7