Audit CLIs - Githubissues

HullSeals / HalpyBOT

The Hull Seals IRC Utility bot, built with Pydle

GNU General Public License v3.0

7 stars 3 forks source link

Audit CLIs #139

Closed Rixxan closed 1 year ago

Rixxan commented 2 years ago

The CLIs are in need of a good overhaul and are ancillary programs attached to HalpyBOT that have not received the same level of polish as the core. We need to perform a full audit run on these programs.

Rixxan commented 2 years ago

In GitLab by @rik079 on Jul 20, 2022, 14:49

BackupFactUpdater: This one I'm happy about. It's a very simple script that does it job, and is in my opinion not in any need of adjustments, now or in the future, except to deal with a potential change in how HBOT deals with facts in offline mode. No such changes are currently planned.

Rixxan commented 2 years ago

In GitLab by @rik079 on Jul 20, 2022, 15:09

EDDBFormatter:

Several variable names don't reflect their function, and make the code a little hard to read. I'll take care of those once I'm done with the review

Rixxan commented 2 years ago

I'd really like it if we could get the CLIs to work globally - ex with pathlib's pathlib.Path(__file__).parent.resolve() or something to automatically feed in the information.

Also removing the config file if possible, if we don't really need them.

Finally, if we can remove all instances of requests and unify under aiohttp across the whole project that'd be fantastic, among other changes.

Rixxan commented 1 year ago

The only remaining CLI to be audited is the DSSA updater. Todo:

[x] Add Globalized Run Logic
[ ] Remove REQUESTS in favor of AIOHTTP? (TBD)
[x] Petition DSSA again to get EDSM-normalized names on the spreadsheet
[x] Remove CONFIG file and integrate

Rixxan commented 1 year ago

mentioned in commit 1c3475a3346c7c8c6b7fa62649d7ff52c57a53dd