[Halpy-123a] Audit Stage One - [merged]

[Rixxan]

Merges feature/Halpy-123a -> develop

Stage one of the 1.6 Complete Feature Audit. Related to #123.

While this does not close the audit, enough changes have been made that this should be reviewed before the next step.

As such, there are still a number of TODOs.

Changes:

• Update of Copyright year
• Reorder Imports
• Update Variable Names to PEP8 Conventions
• Style Updates (using BLACK)
• Removal of redundant Fstrings
• Removal of useless return-else statements
• Refactoring /src/ to /halpybot/
• Removal of unused variables
• Update of various requirements to later versions
• Addition of numerous missing docstrings
• Removal of useless except-raise statements
• Update of a number of invalid links
• Renaming of landmark.json attributes
• Spacing updates on commands.json
• Refactoring of help to bot_help to prevent redefining of inbuilt
• Specify encoding on opened files
• Sacrifice a Goat
• Update exceptions to correct type
• Better Logging of Exceptions
• Prevent Error Messages from containing exception threads
• Begin update of logging to loguru
• Remove redundant information from requirements
• Update logging of errors to be more clear
• Removal of redundant duplicate code in cardinal_flip
• Update Argument Test Logic for Help System
• Completely Rework the EDSM Lookup System (Thanks theunkn0wn1)
• Rename duplicate functions
• Fix incorrect get_help searches
• Rename decorators to PEP8 standards
• Remove fstrings from logging system
• Update True If to BOOL checks
• Remove some keys() search to just dict
• Explicitly add FROM to a number of exceptions
• Remove default arguments from some functions
• Set maxsplit on some fact checks
• Remove some unused imports
• Add a few more tests to EDSM
• Change type() test check to isInstance()
• Make WHOIS more tolerant of Pydle changes
• Fix an incorrectly assigned variable in PartChannel
• Remove the POOL from start.py (@theunkn0wn1)
• Fix a mutable default variable (@theunkn0wn1)

[Rixxan]

requested review from @rik079

[Rixxan]

added 1 commit

• d6d633d5 - [Halpy-123a] Add more docstrings

Compare with previous version

[Rixxan]

added 1 commit

• d84bbe75 - [Halpy-123a] Add More Docstrings

Compare with previous version

[Rixxan]

added 1 commit

• df2e94c4 - [Halpy-123a] Update Var Names

Compare with previous version

[Rixxan]

added 3 commits

• 3edaebf9 - Fixes a crash caused by newer pydle versions
• 44ad6d5d - Fixes obscurity caused by *marginally* incorrect exception instantiation
• 29e3743d - Merge branch 'user/theunkn0wn1/fix_a_crash' into 'feature/Halpy-123a'

Compare with previous version

[Rixxan]

added 1 commit

• 3571df4d - [Halpy-123a] Fix Exception Mistake

Compare with previous version

[Rixxan]

marked this merge request as draft

[Rixxan]

added 2 commits

• ade5e25e - cattr structure Users
• f7e36fce - Merge branch 'user/theunkn0wn1/structure_user' into 'feature/Halpy-123a'

Compare with previous version

[Rixxan]

added 1 commit

• c0990695 - [Halpy-123a] Fix incorrect argument in partchannel

Compare with previous version

[Rixxan]

added 2 commits

• f5d4f0c3 - remove pool
• aa361f04 - Merge branch 'user/theunkn0wn1/drain_pool' into 'feature/Halpy-123a'

Compare with previous version

[Rixxan]

added 1 commit

• 8c7f9732 - [Halpy-123a] Black Changes

Compare with previous version

[Rixxan]

marked this merge request as ready

[Rixxan]

added 1 commit

• ac52228a - [Halpy-123a] Change Import Source

Compare with previous version

[Rixxan]

In GitLab by @rik079 on Mar 27, 2022, 14:23

approved this merge request

[Rixxan]

In GitLab by @rik079 on Mar 27, 2022, 14:24

approved this merge request

[Rixxan]

In GitLab by @rik079 on Mar 27, 2022, 14:24

mentioned in commit 58d68b8c55651ac4577af2749b86163b444c4f3e