[Feature] Add additional processing to EDSM - [merged]

[Rixxan]

Merges feature/edsm-malformed-processor -> develop

This helps HalpyBOT tolerate and process a malformed response from EDSM. This is useful to help specify down where an error is occurring with EDSM in the event of a malformed response, as seen with Abildgaard Jadrake.

[Rixxan]

requested review from @rik079

[Rixxan]

added 1 commit

• ec0bb43b - [Minor] Add Exception Attribution

Compare with previous version

[Rixxan]

added 1 commit

• ffc0ef30 - [Fix] Remove Commented Code

Compare with previous version

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 94

lolwut

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 249

This case doesn't log an exception but others do?

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 208

other exception handlers log the exception, but this doesn't?

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 151

other exception handlers log the exception, but this doesn't?

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 101

other exception handlers log the exception, but this doesn't?

[Rixxan]

In GitLab by @theunkn0wn1 on Jul 31, 2022, 17:16

Commented on halpybot/commands/edsm.py line 348

other exception handlers log the exception, but this doesn't?

[Rixxan]

added 1 commit

• 3005dd18 - [MINOR] Edit case creation with CASEFOLD

Compare with previous version

[Rixxan]

I think this is referencing old code you said was bad and we added the comment but refactored the badness

[Rixxan]

changed this line in version 5 of the diff

[Rixxan]

added 1 commit

• 7e064158 - [Minor] Add a bunch of new logging entries

Compare with previous version

[Rixxan]

Added a lot of new exception logging lines in 7e064158. Let me know if that resolves the issue.

[Rixxan]

resolved all threads

[Rixxan]

In GitLab by @theunkn0wn1 on Aug 6, 2022, 24:01

Commented on halpybot/commands/fact.py line 73

I would be extra warey here, especially since its user input. My paranoia makes me want to pass the maxsplit=1 parameter to the str.split call. YMMV (you may mark this as resolved with no action)

[Rixxan]

In GitLab by @theunkn0wn1 on Aug 6, 2022, 24:01

Commented on halpybot/commands/fact.py line 116

this block of code is duplicated over at least 4 command handlers. consider refactoring.

[Rixxan]

In GitLab by @theunkn0wn1 on Aug 6, 2022, 24:01

Commented on halpybot/packages/announcer/announcer.py line 104

I question if the exception needs to be logged here, especially since you then re-raise the exception. in other words, logging becomes the caller's problem.

[Rixxan]

In GitLab by @theunkn0wn1 on Aug 6, 2022, 24:01

Commented on halpybot/packages/announcer/announcer.py line 101

Conversely, you probably want logging here, so you can have something to work with when someone comes screaming that the twitter stuff doesn't work

[Rixxan]

Out of scope, will move to own issue (#140).

[Rixxan]

Out of scope, will move to own issue (#140).

[Rixxan]

changed this line in version 6 of the diff

[Rixxan]

added 1 commit

• 2b53f7f0 - [Minor] Move Logging to Appropriate Places

Compare with previous version

[Rixxan]

resolved all threads

[Rixxan]

In GitLab by @rik079 on Aug 10, 2022, 16:41

approved this merge request

[Rixxan]

In GitLab by @rik079 on Aug 10, 2022, 16:41

mentioned in commit ac11385437f3a50a610bec1997b4398b38e5e921