search

Huluti / Curtail

Simple & useful image compressor
GNU General Public License v3.0
363 stars 39 forks source link

Fix opening files with Open With... #215

Closed ARAKHN1D closed 5 months ago

ARAKHN1D commented 5 months ago

Because of the way the open signal works, files can also be opened with the CLI now.

I added a default height to the window because it would load the window at a really small height when opening files this way. If my calculations are correct, the default-height it's 8 pixels bigger than the window usually opens. I did that because 500 is a nicer number than 492, and I don't think anyone will care or even notice. I also found that the method the open signal is connected to automatically runs if it's called do_open(), so I went ahead and edited that. If you want that change reverted, I can do that.

I'm also not sure where else to say this, but in the release for 1.9.0, you mentioned my old GitHub account instead of this one on accident. I got locked out of it a while ago and kind of forgot that it existed. My current username has a 1 instead of an I, which is admittedly a small change, but I just thought it'd be good for you to know. Sorry if this wasn't the right place to do it, I'm not sure where else to.

Closes #173.

Huluti commented 5 months ago

Thank you for the fix I will try it!

Does a default height (like the already default width set) could cause issues for mobile devices? like gnome mobile, phosh,...?

Username updated in the release 😉

ARAKHN1D commented 5 months ago

I'm not sure. I looked at other GNOME apps that do work on mobile devices, and they use default width and height so it should be fine. This article about making apps adaptive for mobile doesn't mention anything about default dimensions being a problem, so hopefully it isn't. But, I'm not sure how to make apps work on mobile or how to test them, so maybe it would be best to ask someone more knowledge in this case.

And thank you for updating the username :)

Huluti commented 5 months ago

I think that on mobile these height and width are ignored so let's merge this :)

Thank you for fixing existing bugs!