search

Human-Connection / WebApp

Human Connection is your super tool for social good! Let's go!
https://human-connection.org
MIT License
59 stars 27 forks source link

Answer to a comment #200

Open Mastercuber opened 6 years ago

Mastercuber commented 6 years ago

Is your feature request related to a problem? Please describe. It is a bit weird when I answer to comment of a post and this answer is added at the end of the comment section as new comment.

Describe the solution you'd like I think a better way to handle this is, to put all answers to one comment as a thread under the comment like in other social networks.

Describe alternatives you've considered

Additional context

ghost commented 6 years ago

Hey @Mastercuber

thanks for the suggestion, if I remember correctly we already have that somewhere on the Todo list but with minor priority right now.

If you're able and willing to help and implement it feel free to create a PR.

Cheers, Seb

Mastercuber commented 6 years ago

Hey @sebako86

I never used backpack, vue templates cypress etc. before. But I do have some knowledge in npm, angular and angularjs, Javascript and Typescript. CSS (less, sass), HTML, Grunt, Browserify etc..

On monday I have my last exam, so after that I could see if I can handle that.

Cheers, Armin

ghost commented 6 years ago

Hey @Mastercuber ,

that's fine we can assist you and grow together. If you want feel free to join our discord dev channel here: https://discord.gg/NgVpvx9 and we will help you learn everything you don't know yet ;-)

All the best for your exam! 🥇

Cheers, Seb

Mastercuber commented 6 years ago

Hey @sebako86

Thanks for the discord link and the wishes :-). I will join the channel soon!

Cheers, Armin

roschaefer commented 6 years ago

Hi, I'm currently talking with @Mastercuber on discord. How deep should a nesting of comments be? E.g. Contribution >> Comment >> Reply. Or shall we have unlimited nesting?

I would favour a simple nesting (only comments and replies).

How should a possible implementation look like, shall we add a new model replies with a 1:m association to comments?

appinteractive commented 6 years ago

I would do only one level nasting. Also would I use just a property like „replyedOnCommentId“ or a like on a standard comment.

Mastercuber commented 6 years ago

Ok, first I will try to do it with a new property "replyedOnCommentId".

appinteractive commented 6 years ago

Maybe „parentCommentId“ might be more generic. 😬

Mastercuber commented 6 years ago

See this two PR's: https://github.com/Human-Connection/WebApp/pull/231 https://github.com/Human-Connection/API/pull/145