Human-Logic-Software-LLC / moodle-local_levitate

The Levitate plugin for Moodle enables LMS users to explore a wide range of interactive, immersive, microlearning courses and programs in both English and Arabic.
https://www.levitate.coach/
GNU General Public License v3.0
1 stars 0 forks source link

styles.css not specific enough. #9

Closed danmarsden closed 8 months ago

danmarsden commented 9 months ago

in your styles.css you define a number of generic styles that could clash with core moodle code or other locations where simliar names are used.

Moodle helpfully adds a number of classes to the body tag based on the path that you can use such as: eg if you are have a file in mod/assign you would see the following class added to the body tag path-mod-assign so if you have an item with the class "filething" on the page you would target it like:

.path-mod-assign .filething {
   color: red;
}

Please make sure your css classes in styles.css are specific enough so they cannot clash with other core code.

sreenivasmalae commented 9 months ago

"In the styles.css file, potential clashes with generic styles have been addressed by incorporating specific classes based on the page path. the CSS now includes '.path-local-levitate' to prevent conflicts.

danmarsden commented 9 months ago

doesn't look like you've done this everywhere yet? eg: https://github.com/Human-Logic-Software-LLC/moodle-local_levitate/blob/main/styles.css#L333-L339

(I didn't look further in your styles.css file - just stopped when I saw that...) - you should check it all yourself again :-)

sreenivasmalae commented 9 months ago

I've rechecked the styles.css file and ensured that all the CSS code has been updated to the latest version.