download_model_instance() should strip off "?bluenaas=true" when generating the local file name - Githubissues

HumanBrainProject / hbp-validation-client

A Python package for working with the Human Brain Project Model Validation Framework

http://hbp-validation-client.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2 stars 3 forks source link

download_model_instance() should strip off "?bluenaas=true" when generating the local file name #82

Closed apdavison closed 4 years ago

appukuttan-shailesh commented 4 years ago

From here: https://github.com/HumanBrainProject/hbp-validation-framework/issues/228#issuecomment-443750412 Presently, only models stored in public CSCS storage container have acces to bluenaas feature via the model catalog.

So we can make this fix selectively for URLs starting with "https://object.cscs.ch/", i.e. here: https://github.com/HumanBrainProject/hbp-validation-client/blob/master/hbp_validation_framework/__init__.py#L2127

I suppose we can remove all query parameters, and not just "?bluenaas=true" when generating the local file name, right @apdavison ?

appukuttan-shailesh commented 4 years ago

Implemented in #83