search

HumanBrainProject / hbp-validation-framework

Apache License 2.0
5 stars 12 forks source link

Broken links in web app pages #244

Closed appukuttan-shailesh closed 4 years ago

appukuttan-shailesh commented 5 years ago

The URL's to detailed results pages are broken!

e.g. https://collab.humanbrainproject.eu/#/collab/8123/nav/68490?state=model.21274988-13af-46b2-bbc6-9e15b26f3900

Click on any score, and the URL becomes: https://collab.humanbrainproject.eu/#/collab/8123/nav/68490?state=result.%5Bobject%20Object%5D

@apdavison : do take a look if you find the same.

appukuttan-shailesh commented 5 years ago

Similarly, On the test result page, e.g. https://collab.humanbrainproject.eu/#/collab/8123/nav/68490?state=result.fb247d14-eab9-478b-87b3-0934cb871b8f

The link for "(more details on model catalog)" does not redirect properly.

apdavison commented 5 years ago

This has been fixed for the score links on the staging server. I haven't yet tested the "more details" links.

appukuttan-shailesh commented 5 years ago

Scores links now work.

For the "more details" links:

apdavison commented 5 years ago

The "opening in an invalid model catalog" issue is not a major one, since most people only have one instance of the app installed. We should fix this at some point, but it's a low priority.

appukuttan-shailesh commented 5 years ago

I think this was misunderstood...... it is currently redirecting to an invalid broken URL (with NAV_ID = 68628). An app with this ID does not exist in this Collab.

i.e. https://collab.humanbrainproject.eu/#/collab/8609/nav/68628?state=model.2fc841a2-c5f8-4e47-900e-ff35dfdb7af4,external is invalid and broken

correct URL should have been corresponding to a model catalog instance in that Collab (in this case a single instance with NAV_ID = 407995): https://collab.humanbrainproject.eu/#/collab/8609/nav/407995?state=model.2fc841a2-c5f8-4e47-900e-ff35dfdb7af4

apdavison commented 5 years ago

ok, I was confusing it with a related issue whereby it redirects to a valid Model Catalog app in the same collab, but not the appropriate one (e.g. staging redirecting to production).

apdavison commented 5 years ago

so it turns out that when apps are deleted from the collab, they are not deleted from the vf database, so you were being directed to an app instance that no longer exists in that collab. As a temporary workaround, I've deleted the invalid entries from the database, so it should work now.

To fix this properly, we should change to querying the Collab service API instead of our database. Please leave this ticket open so we don't forget, but I think you can remove the "Critical" label.

appukuttan-shailesh commented 4 years ago

Has been implemented in Collab v2 web apps. v1 apps will soon be dropped.