data_modality -> recording_modality

appukuttan-shailesh commented 4 years ago

Since we renamed data_modality to recording_modality (under Controlled vocabularies), would it be appropriate to rename the same for data under tests. Current v2 REST API for tests returns, e.g.:

{
  "id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
  "uri": "string",
  "name": "string",
  "alias": "string",
  "status": "proposal",
  "author": [
    {
      "given_name": "string",
      "family_name": "string"
    }
  ],
  "species": "Mus musculus",
  "description": "string",
  "date_created": "2020-06-26T12:09:45.723Z",
  "old_uuid": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
  "data_location": [
    "string"
  ],
  "data_type": "string",
  "data_modality": "2-photon imaging",
  "test_type": "behaviour",
  "score_type": "Other",
  "instances": [
    {
      "id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
      "uri": "string",
      "old_uuid": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
      "repository": "string",
      "version": "string",
      "description": "string",
      "parameters": "string",
      "path": "string",
      "timestamp": "2020-06-26T12:09:45.723Z",
      "test_definition_id": "3fa85f64-5717-4562-b3fc-2c963f66afa6"
    }
  ]
}

@apdavison : let me know if you agree.

apdavison commented 4 years ago

Implemented in 25a7d72e

Can you take care of the changes in the Python client?

appukuttan-shailesh commented 4 years ago

Ok :+1:

appukuttan-shailesh commented 4 years ago

https://github.com/HumanBrainProject/hbp-validation-client/issues/74

HumanBrainProject / hbp-validation-framework

data_modality -> recording_modality #269