HumanBrainProject / neuroglancer-scripts

Conversion of neuroimaging data for display in Neuroglancer
MIT License
27 stars 18 forks source link

Make support for Python 3.11 official + fix warnings #30

Closed ylep closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #30 (18e52d1) into master (8513c06) will not change coverage. The diff coverage is 14.28%.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files          25       25           
  Lines        1489     1489           
  Branches      219      219           
=======================================
  Hits         1379     1379           
  Misses         63       63           
  Partials       47       47           
Impacted Files Coverage Δ
src/neuroglancer_scripts/mesh.py 74.11% <0.00%> (ø)
...uroglancer_scripts/scripts/generate_scales_info.py 78.94% <0.00%> (ø)
...r_scripts/scripts/volume_to_precomputed_pyramid.py 90.56% <ø> (ø)
src/neuroglancer_scripts/volume_reader.py 82.69% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

xgui3783 commented 1 year ago

hmm test failed on 3.11 though... I will take a look after my meeting. (unless you beat me to it)

ylep commented 1 year ago

@xgui3783 fixed, it was just a coding style error linked to your other PR. I will merge now. I agree we should make a new release, I recall you had set up an Action to do so but I forgot the details, so I will give it a look! We should probably make this a version 1.1 considering that there were some functional changes... and I don't really see the point of backporting all these commits to the 1.0 branch to make a version 1.0.1.

xgui3783 commented 1 year ago

@xgui3783 fixed, it was just a coding style error linked to your other PR. I will merge now. I agree we should make a new release, I recall you had set up an Action to do so but I forgot the details, so I will give it a look! We should probably make this a version 1.1 considering that there were some functional changes... and I don't really see the point of backporting all these commits to the 1.0 branch to make a version 1.0.1.

@ylep since you have incremented neuroglancer_scripts.__version__, I think all you need to do is create a new release at github.