HumanBrainProject / openMINDS

openMINDS comprises a set of metadata models for research products in the field of neuroscience.
MIT License
40 stars 13 forks source link

Question: part number for electrode object? #53

Open andreagaede opened 1 year ago

andreagaede commented 1 year ago

Is there a field for the catalog or part number of a given electrode/probe in the electrode object? Or does this information belong in deviceType? If so, is it supposed to be a controlled term for 'name' in deviceType?

lzehl commented 12 months ago

Hi @andreagaede

If you are really talking about the catalog (serial) number of a whole device that is provided/assigned by the manufacturer of that device, which is in your case an electrode or an electrode array, the number should be stated under the property "serialNumber" in the schemas "Electrode" or "ElectrodeArray" (both schemas belong to the device category).

If you mean a number that you assigned to the electrode or the electrode array you should state that number / identifier under "internalIdentifier" in the same schemas.

For an electrode array there is additionally the option to list all the identifiers for all the electrodes of the array under the property "electrodeIdentifier" in the schema "ElectrodeArray" and additionally the subset of identifiers for the actually used electrodes of the array under the property "usedElectrode" in the schema "ElectrodeArrayUsage".

Please let us know if this answers your question ?

andreagaede commented 12 months ago

Hi @lzehl

Thanks for your reply!

I guess serial number to me means an individual identifier assigned by the manufacturer for a device/electrode/electrode array. I am wondering where to put the part number or catalog number (again assigned by the manufacturer) that you would use to order an electrode, because this can tell you what the exact format/diameter/resistance/probe type is for a given electrode. Maybe people are using serialNumber for the general catalog number?

"electrodeIdentifier" sounds like it would be for stating which electrode number you are referring to in an array or probe?

lzehl commented 12 months ago

"electrodeIdentifier" sounds like it would be for stating which electrode number you are referring to in an array or probe?

yes, exactly.

Maybe people are using serialNumber for the general catalog number?

This is a good question. From what you right I would say these number do not have the same meaning. A serial number is an identifier for a specific device that was sold while a catalog number identifies the type of device that can be bought / is distributed. Within the device schemas this should be captured under "digitalIdentifier" property but the current value contraints (linked types) do not fit your needs.

@apdavison what do you think? did we not just released a schema for a generic digital identifier that could be used for specifying catalog numbers? Or do we need to reintroduce catalog numbers back into the device schemas?

stevewds commented 11 months ago

Thanks @lzehl : My 2 cents: we found the serialNumber to be straightforward (an individual instance), but the digitalIdentifier a little confusing. It seems you all are intending digitalIdentifier to be for the general model number / catalog number / electrode make. Whereas I usually think of a digitalIdentifier as being some sort of a serial-number-like item that corresponds to an individual instance.

Thanks for discussing!

Steve

lzehl commented 11 months ago

@stevewds thanks a lot for raising this discussion :) I understand the confusion and you are right in the sense that we typically link in other cases under "digitalIdentifier" the one for the instance/entity it is connected to. However digital identifiers (in particular RRIDs) do exist for concepts / groups of entities as well.

Therefore I could imagine both options: (1) stating the catalogue number (overall entity type) of the electrode / electrode array through the digital identifier, or (2) adding a separate property "catalogueNumber" in the device schemas.

I'd like to discuss this further with the other @HumanBrainProject/openminds-developers expecially @apdavison and @Peyman-N