HumanBrainProject / openMINDS

openMINDS comprises a set of metadata models for research products in the field of neuroscience.
MIT License
40 stars 13 forks source link

`@type` disparity bewteen quantitativeValue and UnitOfMeasurement? #7

Closed xgui3783 closed 3 years ago

xgui3783 commented 3 years ago

as of artefact extracted from commit a8d67d1f4598174dec079a1aa75fc50c720e2c24

quantitativeValue had the following schema (trimmed for brevity):

{

        "unit": {
            "_instruction": "Add the unit of measurement of this quantitative value.",
            "else": {
                "properties": {
                    "@id": {
                        "format": "iri",
                        "type": "string"
                    }
                },
                "required": [
                    "@id"
                ]
            },
            "if": {
                "required": [
                    "@type"
                ]
            },
            "then": {
                "properties": {
                    "@id": {
                        "format": "iri",
                        "type": "string"
                    },
                    "@type": {
                        "enum": [
                            "https://openminds.ebrains.eu/controlledTerms/Unit"
                        ],
                        "format": "iri",
                        "type": "string"
                    }
                },
                "required": [
                    "@id"
                ]
            },
            "type": "object"
        }
}

the type https://openminds.ebrains.eu/controlledTerms/Unit does not seem to exist in the repo, but a similar type https://openminds.ebrains.eu/controlledTerms/UnitOfMeasurement exists.

lzehl commented 3 years ago

@xgui3783 thanks for noticing. This is indeed a missing update in the quantitativeValue schema. I'll check and correct it.

lzehl commented 3 years ago

@xgui3783 I just saw it's already corrected. I'll close the issue. Please continue raising issues :) it's great to get feedback and help with detecting errors that might still be in the schemas.