search

HumanBrainProject / openMINDS_instances

The openMINDS_instances repository contains well defined metadata representations (JSON-LDs) that are most likely to be reused across different research products.
MIT License
1 stars 2 forks source link

Preparation type updates #26

Closed UlrikeS91 closed 3 years ago

UlrikeS91 commented 3 years ago

All preparation types have an InterLex ID now. It's slightly inconsistent which is why I want @lzehl and/or @tgbugs to approve/disapprove before merging it. When available, I used "<> design" entries because those have definitions and seems to fit better. If they where not available, I use "<> technique" entry instead. Accordingly, they received the InterLex entry name as synonym as well.

our name --> InterLex name+synonym (comment) ex vivo --> ex vivo design (but technique exists too: http://uri.interlex.org/ilx_0739736) in silico --> in silico (neither "design", nor "technique" in the name) in situ --> in situ technique in utero --> in utero technique
in vitro --> in vitro design (but technique exists too: http://uri.interlex.org/ilx_0739568) in vivo --> in vivo design (but technique exists too: http://uri.interlex.org/ilx_0739622)

What do you think? Do we rather have a mix of "technique" & "design" entries (and be inconsistent) or stick to "technique" only (and lose the definitions/better fitting entries)? If we go for the mix, do we want to add "<> technique" as synonyms too?

tgbugs commented 3 years ago

I would not use design here and stick with technique only. The design of an experiment may include many different techniques, some of which cover the preparation that is used. Having the preparation separate in the interface is an affordance for the users, but behind the scenes having everything modelled as a technique will simplify the structure.

UlrikeS91 commented 3 years ago

I would not use design here and stick with technique only.

Thanks for the feedback, @tgbugs! I changed everything to the technique entries. If @lzehl is happy with everything, she can merge it :)

lzehl commented 3 years ago

@UlrikeS91 I would prefer for our name to not include "technique" at all. Since we have techniques separate it will confuse people. And it fits better with the property (what preparation type was used? in situ vs in situ technique), don't you think? You can add the name with "technique" though to the synonyms.

UlrikeS91 commented 3 years ago

@UlrikeS91 I would prefer for our name to not include "technique" at all. Since we have techniques separate it will confuse people. And it fits better with the property (what preparation type was used? in situ vs in situ technique), don't you think? You can add the name with "technique" though to the synonyms.

That's exactly what I did ;)

lzehl commented 3 years ago

:see_no_evil: sorry @UlrikeS91 (of course you did :wink: ) looks great thanks!

lzehl commented 3 years ago

@UlrikeS91 Could you please update them also on the actual controlledTerms GitHub repo. Note that the instances should be kept there from now on.

UlrikeS91 commented 3 years ago

@UlrikeS91 Could you please update them also on the actual controlledTerms GitHub repo. Note that the instances should be kept there from now on.

Yes, of course! Totally forgot that we changed that...They are update now (committed directly into the v1 branch).