search

HumanBrainProject / openMINDS_instances

The openMINDS_instances repository contains well defined metadata representations (JSON-LDs) that are most likely to be reused across different research products.
MIT License
1 stars 2 forks source link

Add licenses #4

Closed UlrikeS91 closed 3 years ago

UlrikeS91 commented 3 years ago

This should reflect most of the licenses that we are using in the EBRAINS KG at the moment (only non-proprietary).

As discussed with @lzehl, whenever possible, the "legalCode" for each license points to the one from the offical homepage for that license. If no homepage exists, it points to the https://spdx.org/licenses/ entry instead. Under "webpage", I added max 3 webpages:

  1. homepage for the specific license, but not the general homepage (e.g. CC BY has "https://creativecommons.org/licenses/by/4.0" and not "https://creativecommons.org")
  2. https://spdx.org/licenses/ entry
  3. https://opensource.org/licenses/ entry

Not all 3 were always available, but always at least the spdx entry.

@lzehl: In cases were the "legalCode" is the same as the "webpage" (e.g. BSD4), should we remove the "webpage" all together?

lzehl commented 3 years ago

@UlrikeS91 answer to your question: yes, I would remove the webpage then (or did we make it required?).

UlrikeS91 commented 3 years ago

@UlrikeS91 answer to your question: yes, I would remove the webpage then (or did we make it required?).

Nope, not required. I'll remove it :)

  • for a property that has expects a value of type array, the entry always has to be an array event if there is only one item (marked the it for all individual cases that need correction in the JSONs)

My bad! I'll fix that. Some of the ones you comment on will turn into "null" anyway since we don't want a duplication of the "legalCode". But the rest needs to be corrected, of course.

  • (this doesn't have to be corrected now if it is too much work) for a property that has an array as value, it is nicer to read if the array items are distributed over lines. Example:
{
  ...,
  "webpage": [
    "first-IRI",
    "second-IRI",
    "third-IRI"
  ]
}

Makes sense. If you want this to be a general rule, we should start an issue on it in this repo, so that we fix this for all other instances as well (e.g. see synonyms for https://github.com/HumanBrainProject/openMINDS_instances/blob/master/instances/contentTypes/json.jsonld). As you said, it's not urgent. It will only improve the human readability but it's nice to have the issue so we won't forget about it ;)