search

HumanCellAtlas / dcp-community

HCA Data Coordination Platform community content
5 stars 18 forks source link

Import pre-RFC-process-dated DCP Media Types #113

Open kislyuk opened 5 years ago

kislyuk commented 5 years ago

This RFC imports the DCP Media Types design document (https://docs.google.com/document/d/1TqihrgXjct9aDmTJO52_gE2WlpFysB1OkG9C8exmWTw/edit#) that was decided upon prior to the RFC process.

November 19th: Last call for community review

kislyuk commented 5 years ago

Given that this document pre-dates the formal DCP RFC process and is de facto approved and implemented, I plan to bypass the usual process and merge it in after letting it sit for a week. If you have objections or minor edits to propose, please let us know by the end of this week. Barring objections, I'll merge the doc in on Monday, September 23.

mweiden commented 5 years ago

@kislyuk @diekhans please go through the standard RFC process for this. Not doing so sets a precedent that may lead to unexpected outcomes later: people might be lead to believe that they can bypass the process if they implement something first and then publish the RFC.

If the RFC process is too slow, consider adding input to RFC: Proposing changes/updates to the RFC process.

sampierson commented 5 years ago

Matt,

Did you understand the scenario here? This is not about code that was written before there RFC process. This is an RFC that was written before the current RFC process. Are you suggesting that every time we tweak the RFC process, we need to re-review all RFCs?

-Sam.

On Sep 17, 2019, at 4:18 PM, Matt Weiden notifications@github.com wrote:

@kislyuk https://github.com/kislyuk @diekhans https://github.com/diekhans please go through the standard RFC process for this. Not doing so sets a precedent that may lead to unexpected outcomes later: people might be lead to believe that they can bypass the process if they implement something first and then publish the RFC.

If the RFC process is too slow, consider helping build solutions to the problem in RFC: Proposing changes/updates to the RFC process https://github.com/HumanCellAtlas/dcp-community/pull/109.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HumanCellAtlas/dcp-community/pull/113?email_source=notifications&email_token=AADLV2UGY2MW6SOVDJDLWKTQKE3SZA5CNFSM4IXEMAZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD65YZKA#issuecomment-532384936, or mute the thread https://github.com/notifications/unsubscribe-auth/AADLV2WZVCLR4ZVLA4CITNDQKE3SZANCNFSM4IXEMAZQ.

sampierson commented 5 years ago

Ping @mweiden Regarding my comment above. This RFC was reviewed by the Arch team in October 2017, using the Google Docs review mechanism. Review was started here https://humancellatlas.slack.com/archives/C6SGU0R3J/p1508792188000502 Do you still want it to be reviewed again?

mweiden commented 5 years ago

Discussed during the 2019-10-11 Arch meeting. We reached consensus on importing all old RFCs from google drive and labeling them "Imported."

diekhans commented 5 years ago

I believe it is important to put all labels at the start of the document as well as github labels so it is easy to see when reading.

maniarathi commented 5 years ago

Updated to import DCP Media Types again.

diekhans commented 5 years ago

note: I will be importing the domain RFC ~ Nov 13th

diekhans commented 5 years ago

I don't see the value in putting these into a special directory "imported". This just creates a special case because of being reviewed with a different process. I think the idea is for these to be first-class RFCs just like all the others. We don't really want to have a new directory every time we change the RFC process.