search

HumanCellAtlas / dcp-feedback

Please file issues here for feedback, feature requests, bugs, and comments on the Data Coordination Platform
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

smoking_history "yes" values, what do they mean? #21

Open PeterWoollard opened 4 years ago

PeterWoollard commented 4 years ago

Describe the bug What does "yes" in that field mean in the " immune cells study" please? We assume it means that that the subject was a smoker rather than simply the PI has the smoking history of subjects. In other studies like tissue stability, it neatly reflects what it is in the definition in https://github.com/HumanCellAtlas/metadata-schema/blob/master/json_schema/module/biomaterial/medical_history.json

Thanks, Peter BTW: we continue to b impressed by your data modelling and transparency.

NoopDog commented 4 years ago

Hi @PeterWoollard I have forwarded this on to the support team. Thanks for the question.

mshadbolt commented 4 years ago

Hi @PeterWoollard I agree that this description is quite vague. The 'yes' in this case does mean that this donor has a smoking history but unfortunately we do not have any further details about the time or frequency of the smoking history.

We will look into making this clearer for a future release.

Thanks for your kind words about our metadata, we put a lot of work into making it as clear and accurate as possible so it is good to know that the community finds it useful. We always welcome feedback and appreciate you getting in touch.

Marion (on behalf of the HCA Metadata team)

PeterWoollard commented 4 years ago

Hi Marion, Thank you for the reply, that will help us interpret this. Yes, if the definition in the dictionary and JSON are updated in a future release, that will help others,

Best Regards, Peter

On Thu, 6 Aug 2020 at 10:58, Marion notifications@github.com wrote:

Hi @PeterWoollard https://github.com/PeterWoollard I agree that this description is quite vague. The 'yes' in this case does mean that this donor has a smoking history but unfortunately we do not have any further details about the time or frequency of the smoking history.

We will look into making this clearer for a future release.

Thanks for your kind words about our metadata, we put a lot of work into making it as clear and accurate as possible so it is good to know that the community finds it useful. We always welcome feedback and appreciate you getting in touch.

Marion (on behalf of the HCA Metadata team)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HumanCellAtlas/dcp-feedback/issues/21#issuecomment-669834517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESVEVIMOB4V4VMNDUWDY6LR7J5ELANCNFSM4PQNHZZQ .

-- Kind Regards, Peter Peter Woollard