search

HumanCellAtlas / dcp

Data Coordination Platform manifest and integration tests.
3 stars 1 forks source link

PR-based integration tests with automatic deployment #81

Open rhiananthony opened 6 years ago

rhiananthony commented 6 years ago

https://docs.google.com/document/d/17tvOujycch6VXRmYWh6LYo1MaZyf2YuYEyB_-9LrrII/edit#heading=h.2rlu4knkzel9

Other ACs:

rhiananthony commented 6 years ago

Kylee - May 22, 2018 - 11:21AM After #48 we will need to implement integration tests. The goal is to be able to confidently use automated deployment from integration->staging after we implement these tests.

Kylee - May 2, 2018 - 7:11PM I believe Hannes is working on this hopefully in time for the May f2f

Rex - Apr 30, 2018 - 5:47PM Started to draft a doc for this: https://docs.google.com/document/d/1cFKXAGeKee4uR5HNXJgLy8sPpJLN1gSVKyJpedsG0U0/edit#heading=h.xgjl2srtytjt

hannes-ucsc commented 6 years ago

We do have an inter-box integration test. So what more needs to be added?

kbergin commented 6 years ago

A comment from @kislyuk in slack on 9/25 on integration tests that I wanted to document somewhere.

For all but the lowest level changes, my suggestion is to have a DCP-wide PR-based integration test environment. i.e. for any PR, the test would redeploy all components fully automatically from an integration branch, except for the PR component (which would deploy from the PR branch) and the integration test would run. We would want to make the deploy/integration process as fast as possible for this, and tests would need to be serialized not to step on each other’s toes. But that would give us a platform to quickly detect issues without forcing rollbacks.

... Similar to how green has mintegration test..

Imagine we just generalized this to all other services though a test facility centralized in gitlab

sampierson commented 5 years ago

This is a "nice to have". I'm changing the title from "Integration Tests", which we have, to "PR-based integration tests with automatic deployment" and am ice-boxing it.

brianraymor commented 5 years ago

I'm not sure that "nice to have" meets the bar for Icebox? This is ~8 months old. @kislyuk - are there any plans to develop or pursue ideas further?