search

HumanCellAtlas / dcp2

Shared artifacts concerning the Human Cell Atlas (HCA) Data Coordination Platform (DCP)
4 stars 2 forks source link

Remove dashes from project UUID in snapshot names (#28) #29

Closed hannes-ucsc closed 3 years ago

kbergin commented 3 years ago

I'm going to ask Nikelle to review this in my place.

hannes-ucsc commented 3 years ago

I'm going to ask Nikelle to review this in my place.

@kbergin, could you try cancelling my the review request and requesting Nikelle directly here on the PR user interface?

Does this require any changes to the adapters?

No, @jessicaway.

kbergin commented 3 years ago

Ok, fixed. @jessicaway 's review works instead too, just wanted it to be an eng from my team.

hannes-ucsc commented 3 years ago

Thanks for all the quick reviews. @ruchim and I discussed this today. It is possible that we won't need this since upcoming TDR changes eliminate the derivation of BQ dataset names from TDR snapshot/dataset names, removing the constraint that TDR snapshot or dataset names not contain dashes. If those changes land in the new prod instance of TDR soon enough, we will not need this.

We should sit on this for a bit until @ruchim knows when these TDR changes will land in the new prod instance of TDR. At that point we'll decide if we merge and later revert or if we just close this without merging. I want to avoid having mixed naming conventions for snapshots in TDR new prod, so we should decide before @aherbst-broad creates the first per-project snapshot in TDR new prod.