search

HumanCellAtlas / dcp2

Shared artifacts concerning the Human Cell Atlas (HCA) Data Coordination Platform (DCP)
4 stars 2 forks source link

Add section capturing external DRS URIs #55

Closed aherbst-broad closed 1 year ago

aherbst-broad commented 2 years ago

Context

The Lungmap project has a requirement to source files from an external system that will provide DRS URIs. These files will not be importable to TDR but the DRS URIs will need to be wired through into the file descriptor so they can be surfaced downstream in the browser. This is a draft PR capturing a proposal to allow the inclusion of these external DRS URIs.

Related schema PR

aherbst-broad commented 2 years ago

@hannes-ucsc Thanks for the look, I've updated per your comments.

hannes-ucsc commented 2 years ago

I'll review the schema PR when we've settled this one.

hannes-ucsc commented 2 years ago

@aaclan-ebi FYI this relates to file descriptors, too.

hannes-ucsc commented 2 years ago

@aherbst-broad when do you think you'll have time to tend to this. No pressure.

aherbst-broad commented 2 years ago

Hello @hannes-ucsc I've updated with your suggestions, please take a look.

hannes-ucsc commented 2 years ago
image

because they have been removed from the list of designated reviewers as per their request:

https://github.com/HumanCellAtlas/dcp2/commit/2a3cfb1bb1efbe6b6c4ff73e8bcad100c91f928d https://github.com/HumanCellAtlas/dcp2/commit/3d9a0b5e37b2cfa4ce4d24a1f35b98844f76e68f