HumanCellAtlas / fusillade

Federated User Identity Login & Access Decision Engine
https://fusillade.readthedocs.io/
Other
8 stars 1 forks source link

Adding ResourceNotFound Error when user does not have access to resource #368

Closed Bento007 closed 4 years ago

Bento007 commented 4 years ago

When a user tries to access a controlled access resource they do not have any access privileges to, the object appears as if it does not exist. A user should not know about resources they do not have access to.

codecov-io commented 4 years ago

Codecov Report

Merging #368 into tsmith/auto-provision will decrease coverage by 0.06%. The diff coverage is 80%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           tsmith/auto-provision     #368      +/-   ##
=========================================================
- Coverage                  89.53%   89.46%   -0.07%     
=========================================================
  Files                         34       34              
  Lines                       2197     2203       +6     
=========================================================
+ Hits                        1967     1971       +4     
- Misses                       230      232       +2
Impacted Files Coverage Δ
fusillade/directory/authorization.py 100% <100%> (ø) :arrow_up:
fusillade/errors.py 94.11% <100%> (+0.78%) :arrow_up:
fusillade/api/evaluate.py 88.57% <50%> (-5.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e5831c...950d62a. Read the comment docs.