HumanCellAtlas / ontology

3 stars 1 forks source link

Questions about spatial resolution of UBERON ontologies #48

Closed mshadbolt closed 3 years ago

mshadbolt commented 4 years ago

As a data wrangler for the WSSS projects I need to try to match the spatial organ terms they are using with suitable ontology organ and organ part ontologies. There are a few organs where there are gaps in specific spatial ontologies and I want to understand if these are terms that could/should be added to UBERON, or if we need to look in to using an alternate ontology, e.g. Biological Spatial Ontology to get a more specific definition of the spatial area the specimen was taken from. Some examples I have so far are:

Kidney

Uterus

Small Intestine

Bone

Liver

We have also had feedback from CBTM who think that they need more fine grained terms to accurately capture some of the samples they are collecting from organs.

mshadbolt commented 4 years ago

@zoe @simonjupp was just wondering if you have any thoughts about how to get better spatial resolution when defining where specimens are being taken from within organs.

simonjupp commented 4 years ago

If we can standardise to a common model on the spatial index, then we should look to add this as a new property in the metadata schema so users can provide alongside the uberon term for the primary biopsy site name.

For the specific biopsy site, many of these should already be covered by Uberon/FMA (https://www.ebi.ac.uk/ols/ontologies/fma). It would be good to get a list of the ones you've encountered that didn't map to anything.

mshadbolt commented 4 years ago

See the first post of the ticket for a list of organ parts that don't map to terms in the uberon ontology. We don't use the FMA ontology.

mshadbolt commented 4 years ago

@simonjupp do you think we should add the FMA ontology to our schema to allow a wider variety of anatomy terms to be used for organ parts?

simonjupp commented 4 years ago

We can import from FMA. These will end up as subclasses of uberon terms in the HCAO so it won't effect validation. Just let @zoependlington know the list of FMA terms you want.

mshadbolt commented 4 years ago

I made a ticket (#54) to add some terms from the FMA as children of organ terms in UBERON in our HCAO

paolaroncaglia commented 3 years ago

Hi @mshadbolt,

I made a ticket (#54) to add some terms from the FMA as children of organ terms in UBERON in our HCAO

Any objection if I close this ticket as a duplicate of #54? I will then look into #54 and address any missing task (I see that Zoë has already done some work).

Thanks, Paola

mshadbolt commented 3 years ago

ok sounds good