Stop pullapprove on skylab from adding random reviewers who are not on the team

HumanCellAtlas / secondary-analysis

Secondary Analysis Service of the Human Cell Atlas Data Coordination Platform

https://pipelines.data.humancellatlas.org/ui/

BSD 3-Clause "New" or "Revised" License

3 stars 2 forks source link

Stop pullapprove on skylab from adding random reviewers who are not on the team #663

Closed kbergin closed 5 years ago

kbergin commented 5 years ago

Why? It's annoying, and wasted peoples time

Where do I start?

Pull approve on skylab
Might have to review the lists on which pull approve makes its recommendations

ACs:

Pull approve on skylab adds reviewers from lantern or adds no reviewers and we do this manually

┆Issue is synchronized with this Jira User Story

kbergin commented 5 years ago

https://github.com/HumanCellAtlas/skylab/pull/249/files ( https://github.com/HumanCellAtlas/skylab/pull/249/files|smart-link )

kbergin commented 5 years ago

➤ Jessica Way commented:

QA: Make a PR into Skylab (real or test). Once tests finish, check that pull approve did not request any reviewers. If your PR was just a test, delete it.