search

HumanCellAtlas / secondary-analysis

Secondary Analysis Service of the Human Cell Atlas Data Coordination Platform
https://pipelines.data.humancellatlas.org/ui/
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Add support for SS2 Mouse #674

Closed kbergin closed 4 years ago

kbergin commented 5 years ago

The required info should be here: https://broadinstitute.slack.com/archives/CESEYJW9W/p1561567069254000

┆Issue is synchronized with this Jira Story

ambrosejcarr commented 5 years ago

The required information is here.

kbergin commented 5 years ago

➤ Charles Yan commented:

I think this only involves following completion of this ticket https://broadinstitute.atlassian.net/browse/GH-357 ( https://broadinstitute.atlassian.net/browse/GH-357|smart-link ) and then updating subscription queries to “flip the switch” on ss2 mouse bundles.

kbergin commented 4 years ago

➤ Saman Ehsan commented:

This PR updates the subscription queries to match mouse or human data:https://github.com/HumanCellAtlas/lira/pull/186 ( https://github.com/HumanCellAtlas/lira/pull/186|smart-link )

kbergin commented 4 years ago

➤ Saman Ehsan commented:

For QA, send a notification to Lira for a bundle that contains mouse data (preferably in integration) and confirm that it launches an analysis workflow.

kbergin commented 4 years ago

➤ Chengchen Wang commented:

QAed with: https://job-manager.caas-prod.broadinstitute.org/jobs/278119e7-215e-431b-9254-2411176b2d0a ( https://job-manager.caas-prod.broadinstitute.org/jobs/278119e7-215e-431b-9254-2411176b2d0a )

(The error is not related to this PR, and was due to Ingest doesn’t know the bundles that created manually)

kbergin commented 4 years ago

➤ Saman Ehsan commented:

Ok! Just curious how did you create the bundle if it wasn’t through ingest?