AttachBarcodes V3 Code Path is Tested

[kbergin]

﹍Why?:﹍ Maintain good testing coverage of sctools. The work to make attachbarcodes work for v3 data was done during the pipeline surge and may not have been adequately tested in the unit tests.

﹍Where do I start?﹍: Talk with Saman and Rex and jump into the sctools repo.

﹍AC﹍:

• AttachBarcodes V3 code path is tested as required

┆Issue is synchronized with this Jira Dev Task

[kbergin]

➤ Nick Barkas commented:

PR is here: https://github.com/HumanCellAtlas/sctools/pull/68 ( https://github.com/HumanCellAtlas/sctools/pull/68|smart-link )

[kbergin]

➤ Nick Barkas commented:

[~accountid:557058:e7a77efa-e9f2-457c-9df7-a35b2e8cce0d] pr linked above

[kbergin]

➤ Nick Barkas commented:

[~accountid:557058:e7a77efa-e9f2-457c-9df7-a35b2e8cce0d] Also to note Rex, who is very familiar with sctools, has already looked at this, we only need a internal team check to merge

[kbergin]

➤ Nick Barkas commented:

I was about to merge this, but I noticed that the tests that were failing on my local runs are now also failing on circleci – these are not related to the new code. What does the team want to do?

[kbergin]

➤ Nick Barkas commented:

merged

[kbergin]

➤ Nick Barkas commented:

QA Instructions:

• Checkout sctools: https://github.com/HumanCellAtlas/sctools/ ( https://github.com/HumanCellAtlas/sctools/|smart-link )
• Read over file: https://github.com/HumanCellAtlas/sctools/blob/master/src/sctools/test/test_platform.py ( https://github.com/HumanCellAtlas/sctools/blob/master/src/sctools/test/test_platform.py|smart-link )and confirm ok
• Run pytest from the root directory of the repository, confirm that the test_platform test_attach_barcodes() does NOT fail. Other tests are expected to fail

[kbergin]

➤ Jessica Way commented:

looks good! test_platform test passes