HumanCellAtlas / secondary-analysis

Secondary Analysis Service of the Human Cell Atlas Data Coordination Platform
https://pipelines.data.humancellatlas.org/ui/
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Refactor Optimus Parameterization with respect to input chemistry #805

Closed kbergin closed 5 years ago

kbergin commented 5 years ago

Why do we want to do this?

Required to release this pipeline to production

The Optimus pipeline work done during the pipeline surge to support 10X V3 as a boolean V2 vs V3. We know that we plan to extend Optimus to analyze more datatypes, so we think we should extend this parameterization to more easily support more assays.

Where to start?

AC:

┆Issue is synchronized with this Jira Dev Task

kbergin commented 5 years ago

➤ Nick Barkas commented:

I’ve done this, but adding a second PR test for the same pipeline is not currently supported. Need to talk with other team members to find out best way to do this

kbergin commented 5 years ago

➤ Nick Barkas commented:

Added functionality to support multiple types of tests in our tests (not just ‘PR’). The tests default to ‘PR’ so no change necessary to existing code. Added new test. Currently blocked by requirement to modify circleci config (approvers are away), lack of CB review and Eng review.

kbergin commented 5 years ago

➤ Nick Barkas commented:

Need CB approval from [~accountid:5ba003187ec0fb2e420b1942] or [~accountid:557058:f258569c-acb2-4486-a9e8-96dc2d9ec8d1] and response on eng review from [~accountid:557058:36e7f1cd-a074-4b69-8e9d-730ffdc144e9] to be able to proceed

kbergin commented 5 years ago

➤ Nick Barkas commented:

QA Instructions: Check the current merged code and confirm that the chemistry parameter is the in optimus: https://github.com/HumanCellAtlas/skylab ( https://github.com/HumanCellAtlas/skylab|smart-link )

kbergin commented 5 years ago

➤ Trevyn Langsford commented:

Chemistry parameter is there