HumanCellAtlas / secondary-analysis

Secondary Analysis Service of the Human Cell Atlas Data Coordination Platform
https://pipelines.data.humancellatlas.org/ui/
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Move HCA pipelines to WDL 1.0 #859

Closed kbergin closed 4 years ago

kbergin commented 4 years ago

This will cause ripple effects in the infrastructure because the adapters are not in WDL 1.0.

Move Optimus and SS2 to WDL 1.0

Why?

To have access to the latest features and for ease of maintenance going forward, and we need to update the pipeline to handle other assays in the future.

Where do I start?

ACs:

┆Issue is synchronized with this Jira User Story

kbergin commented 4 years ago

➤ Nick Barkas commented:

Based on discussions with Adam Nichols, this has the potential result in alot of downstream work as the adapters need to be updated as well and we need to ensure that we are not breaking Optimus in prod.

kbergin commented 4 years ago

An additional note here is that if we update to 1.0 we currently can’t put the workflow into Terra, but they are working to upgrade that.

kbergin commented 4 years ago

➤ Nick Barkas commented:

Most things, including ss2 single and multisample as well as Optimus work now. the SS2 tests for multisample, but not single sample fail and require further investigation

kbergin commented 4 years ago

Awesome!!!

kbergin commented 4 years ago

➤ Nick Barkas commented:

Optimus mouse tests fail because they are on older test script. Made ticket to fix separately.

kbergin commented 4 years ago

➤ Nick Barkas commented:

QA Instructions:

kbergin commented 4 years ago

➤ Jessica Way commented:

optimus PR test ( https://job-manager.caas-prod.broadinstitute.org/jobs/163f3644-1826-4c77-98c8-ca5addc5fc3a?q=id%3D163f3644-1826-4c77-98c8-ca5addc5fc3a ) and ss2 PR test ( https://job-manager.caas-prod.broadinstitute.org/jobs/2349811c-3f1d-4b43-90bf-8c405f49fa53?q=id%3D2349811c-3f1d-4b43-90bf-8c405f49fa53 ) both passed