HumanCompatibleAI / imitation

Clean PyTorch implementations of imitation and reward learning algorithms
https://imitation.readthedocs.io/
MIT License
1.33k stars 249 forks source link

SQIL and PC performance check fixes #811

Closed ernestum closed 1 year ago

ernestum commented 1 year ago

Description

Fixes #807 Fixes #791

Testing

Changes are covered by the existing tests.

codecov[bot] commented 1 year ago

Codecov Report

Merging #811 (1b20336) into master (20366b0) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   95.67%   95.63%   -0.05%     
==========================================
  Files         100      100              
  Lines        9581     9582       +1     
==========================================
- Hits         9167     9164       -3     
- Misses        414      418       +4     
Files Coverage Δ
tests/algorithms/test_preference_comparisons.py 100.00% <100.00%> (ø)
tests/algorithms/test_sqil.py 93.67% <100.00%> (-6.33%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ernestum commented 1 year ago

Hi @AdamGleave would you review and merge? The coverage went down since I disabled the SQIL performance tests for now.