Corrections to the requirements file (issue #32) and additional information about human-human gameplay

HumanCompatibleAI / overcooked-demo

Web application where humans can play Overcooked with AI agents.

55 stars 26 forks source link

Corrections to the requirements file (issue #32) and additional information about human-human gameplay #35

Closed alexlichtenstein closed 2 years ago

alexlichtenstein commented 2 years ago

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1202320259519261
- https://app.asana.com/0/0/1202320259519254

micahcarroll commented 2 years ago

Thanks Alex for the first PR! 🚀

One thing that is not clear from the above: did you perform any checks to see whether the changes in the requirements file don't break anything downstream? Might be useful to document that in the PR.

Also, generally it might be useful to split PRs by individual features added / issues addressed. In this case it doesn't really matter because both issues are very small, but the PR name only covers one of the changes.

micahcarroll commented 2 years ago

Hi Alex, just as another comment here, the .github/workflows/check_code.yml file is empty – I'm guessing this was a mistake?

micahcarroll commented 2 years ago

Hi @alexlichtenstein, we should probably delete the .github/workflows/check_code.yml file from this PR (as we're dealing with that in #38). We can then update the human-human gameplay instructions, and merge this in, so we unblock #38 from being merged too.