HumanCompatibleAI / overcooked_ai

A benchmark environment for fully cooperative human-AI performance.

https://arxiv.org/abs/1910.05789

MIT License

714 stars 152 forks source link

Tutorial+petting zoo #123

Closed jyan1999 closed 1 year ago

jyan1999 commented 1 year ago

Description

Added a tutorial notebook

Added PettingZoo environment

Fixes # (issue)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

codecov[bot] commented 1 year ago

Codecov Report

Merging #123 (93f3dd4) into master (55158d5) will increase coverage by 0.29%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   82.15%   82.44%   +0.29%     
==========================================
  Files          16       16              
  Lines        3709     3759      +50     
==========================================
+ Hits         3047     3099      +52     
+ Misses        662      660       -2

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

elliottower commented 1 year ago

Left some comments, don’t have a chance to run through the code tho

elliottower commented 1 year ago

Any update on this? Looks like it hasn't been worked on in a few weeks. Can help out reviewing more code if need be

micahcarroll commented 1 year ago

@jyan1999 is not actively working on this project anymore, so things may be a bit slower. @jyan1999, do you expect to wrap this up / get round to this anytime soon? Otherwise, I can step in! Just let me know 😄

jyan1999 commented 1 year ago

Yes, sorry! I have been busy traveling for the past 2 weeks. I do plan to wrap this up in the next day or two.

jyan1999 commented 1 year ago

Hi @elliottower I have made some updates and addressed your comments. Let me know if there is anything missing and I will be happy to look into them, otherwise I think this looks good for now.

elliottower commented 1 year ago

Cool to see it passing the workflow now, I’ll update the third party environments listing soon once this is merged. Just FYI don’t remember which version of PZ this was but 1.23.1 is out and is a slight bug fix from 1.23.0 (which was the API change with returning obs, info)

jyan1999 commented 1 year ago

Cool to see it passing the workflow now, I’ll update the third party environments listing soon once this is merged. Just FYI don’t remember which version of PZ this was but 1.23.1 is out and is a slight bug fix from 1.23.0 (which was the API change with returning obs, info)

Yes the current version is working with 1.23.1. The API change was what was causing the workflow to fail.