search

HumanCompatibleAI / overcooked_ai

A benchmark environment for fully cooperative human-AI performance.
https://arxiv.org/abs/1910.05789
MIT License
714 stars 152 forks source link

Installation verification shows error #136

Closed sunamatya closed 9 months ago

sunamatya commented 10 months ago

After following the instructions as per https://github.com/HumanCompatibleAI/overcooked_ai, when verifying the installation was checked, the test fails. I have tried installing the program in both windows and ubuntu and the error still persists. Attached with this comment is the error. failed_overcooked_installation

micahcarroll commented 10 months ago

Hi there, thanks for opening the issue!

I just reran the Github actions workflow and it seemed to work fine.

I also wasn't able to reproduce the issue locally, which is surprising if you got the same error on two separate machines (is that the case?). In any case, I'm not entirely sure what the issue is caused by without being able to reproduce it.

boshenzh commented 9 months ago

@sunamatya Hi, I have the same issue, Were you able to solve it? I am running on windows. Here is my full log. log (2).txt

jyan1999 commented 9 months ago

Hi @boshenzh @sunamatya I was able to reproduce this issue on windows, and the problem is the weird default Windows encoding standard not being UTF-8, and when testing we print to a file that contains the upward arrow key, which cannot be recognized by the windows encoding scheme and was causing an error. The permission error is related as we were manually opening and closing the log file before, so when writing failed the file was never closed.

I have pushed a fix to address that. Thx for catching this! (Pro tip: tbh just use Mac or Linux)

boshenzh commented 9 months ago

@jyan1999 Thank you for following up! That solves the issue. (also thank you for your tips ;) )

micahcarroll commented 9 months ago

Thanks so much @jyan1999 for figuring this out!