HumanCompatibleAI / overcooked_ai

A benchmark environment for fully cooperative human-AI performance.
https://arxiv.org/abs/1910.05789
MIT License
683 stars 144 forks source link

Update ppo_rllib_client.py #137

Closed nabazar closed 4 months ago

nabazar commented 5 months ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Checklist:

nabazar commented 5 months ago

Hi Dear, The updated version will look something like this:

from ray.rllib.algorithms.ppo import PPO instead of...

from ray.rllib.agents.ppo import PPO

micahcarroll commented 4 months ago

Why are you making this change? Is it because rllib has updated? If so, we won't default the newer version of rllib unless someone makes a PR which comprehensively fixes issues throughout the repo

nabazar commented 4 months ago

Hi Thank you for your reply I need your help to resolve the resulted issues and errors when I run your code. I want to resolve the following issues:

  1. I want to rewrite the code in colab.is it applicable?

  2. When I run your code I face the following error: import ray from ray.rllib.agents.ppo import PPOTrainer No module named 'ray.rllib.agents'

  3. It seems I should use the non-updated version of the rlib library

Would you please help me with this?

Best regards Nemat

On Mon, Apr 22, 2024, 1:24 AM Micah Carroll @.***> wrote:

Why are you making this change? Is it because rllib has updated? If so, we won't default the newer version of rllib unless someone makes a PR which comprehensively fixes issues throughout the repo

— Reply to this email directly, view it on GitHub https://github.com/HumanCompatibleAI/overcooked_ai/pull/137#issuecomment-2068214164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJQSXS3TJ6GISBZNPOE75DY6QYTBAVCNFSM6AAAAABFCGVCUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGIYTIMJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

micahcarroll commented 4 months ago

Are you installing ray using pip install -e .[harl]?

Because it seems like you may have the wrong version

nabazar commented 4 months ago

Thank you, sir, I will do

On Wed, Apr 24, 2024 at 9:20 PM Micah Carroll @.***> wrote:

Are you installing ray using pip install -e .[harl]?

Because it seems like you may have the wrong version

— Reply to this email directly, view it on GitHub https://github.com/HumanCompatibleAI/overcooked_ai/pull/137#issuecomment-2075511476, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJQSXUAOSM7ABUUHRSKQDTY67WGFAVCNFSM6AAAAABFCGVCUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGUYTCNBXGY . You are receiving this because you authored the thread.Message ID: @.***>