search

HumanDynamics / openbadge

MIT License
49 stars 19 forks source link

BadgeFramework has issues with protocol definitions #101

Closed OrenLederman closed 5 years ago

OrenLederman commented 5 years ago

The types of most fields in the implementation is signed, but the actual type is signed. This might create issues with some of the data, at some point.

OrenLederman commented 5 years ago

The correct protocol can be found here - https://github.com/HumanDynamics/openbadge/wiki/Communication-protocol#scanning-firmware-release-12

OrenLederman commented 5 years ago

And here https://github.com/HumanDynamics/openbadge/blob/master/firmware/nRF_badge/data_collector/incl/sender.h

OrenLederman commented 5 years ago

Fixed in #104