OrenLederman
commented
6 years ago We should force the protocol to accept both badge and project id. They can be 0's though
Closed OrenLederman closed 6 years ago
OrenLederman
commented
6 years ago We should force the protocol to accept both badge and project id. They can be 0's though
In badge_protocol.py (the old protocol-implementation) l.114 and 115 the badge_id and group_number is only set, when != 0. So if one of them is 0, the serialized message doesn't contain the "0" anymore, it is just ignored. So my implementation of the old-protocol assumes that both id and group number is transmitted at the same time. And I think the old firmware also assumes it, because it checks for the length of the received message, and this shouldn't match anymore.