search

HumanLearning2021 / HumanLearningApp

GNU General Public License v3.0
3 stars 2 forks source link

Feature/92 learning with arbitrary nb of categories #154

Closed Nitwix closed 3 years ago

Nitwix commented 3 years ago

Closes #92

Nitwix commented 3 years ago

The following tests fail. I will relaunch once the PR has been approved in order to not overload the CI.

`com.github.HumanLearning2021.HumanLearningApp.model.DummyDatabaseServiceTest > removeCategoryAlsoRemovesFromDatasets FAILED java.util.ConcurrentModificationException at DummyDatabaseServiceTest.kt:170

com.github.HumanLearning2021.HumanLearningApp.model.DummyDatabaseServiceTest > removeCategoryWorks FAILED java.util.ConcurrentModificationException at DummyDatabaseServiceTest.kt:162

com.github.HumanLearning2021.HumanLearningApp.model.DummyDatabaseManagementTest > removeCategoryWorks FAILED java.util.ConcurrentModificationException at DummyDatabaseManagementTest.kt:134

com.github.HumanLearning2021.HumanLearningApp.model.DummyDatabaseManagementTest > getDatasetsWorks FAILED java.lang.AssertionError at DummyDatabaseManagementTest.kt:228`

Nitwix commented 3 years ago

The ConcurrentModificationExceptions came from the dummy database service. The cause is that we modify a collection while it is being iterated on. This will take some time to fix, and I don't have the courage to start this now. So I will merge this in next sprint.