search

HumanLearning2021 / HumanLearningApp

GNU General Public License v3.0
3 stars 2 forks source link

Feature#198/login persistance #202

Closed Jaakik closed 3 years ago

bbjubjub2494 commented 3 years ago

I don't think it's an acceptable solution to store (duplicatively) the user's profile in the preference and then fake a log-in in the interface. The model (or the firebase library) should be authoritative on user status, especially given that authentication happens in the back-end.

The correct solution in my view, would be to make sure that the log-in state is accurate in the presenter.

Discussed in private, this is actually a relatively common practice.

Jaakik commented 3 years ago

some details are not perfect but mergable

Yes, they will be taken in the next sprint, mainly the signOut and datasetediting button, and rethink the login persistance