v3 miscellaneous TODO - Githubissues

tmfrnz commented 4 years ago

Header

[x] search should be a button with label "search"
[x] change subject order: rights | countries | people
[x] search active index should reset on text change

Home

[x] TBD: people slider (more consistent) or people intro (more engaging)
[x] use new metric icons on homepage
[x] fix metric icon alignment on FF
[x] update intro section 3 stripes
[x] change subject order in data section: rights | countries | people
[x] change section order: intro | data | rights | countries | search | people | ...
[x] make top search box more obvious (taller, and text brighter).
[x] consider diamonds for country slider
[x] footer move text to right side
[x] consider other light colours (light salmon, light blue)
[x] (country) tiles should have same height when in same row
[ ] Photo gallery transitions

Country overview

[x] put countries on cards
[x] update breadcrumb (check with AM)
[x] consider adding diamond key on left hand side (may need input from Adina)
[x] assessment filter broken
[x] ~settings include text for scale toggle~
[x] consider adding note to explain HI (or move it into How to Read?)
[x] add search box (may need guidance from Adina)
[x] add spacing to header to make it feel calm (Adina) // reduce height (AM) ???
[x] add light background
[x] allow long metric labels in tooltip

Single country

[x] update breadcrumb (check with AM)
[x] country about: hide tags and include a show more button

Country snapshot #114

[x] add benchmark
[x] category title should trigger about/link overlay
[x] ESR narrative title
[x] CPR show N/A unavailable dimension score
[x] show rights scores
[x] change summary charts to include lollipop marker for category scores (instead of having it on the side, smaller than current numbers
[x] move rights type line in line with category title
[x] remove adjusted benchmark when viewing global best
[x] style explore links

Country details #107

[x] add benchmarks
[x] category tites CPR
[x] over time chart container Empowerment
[x] indicator chart (ESR)
[x] metric dropdown
[x] indicator chart raw option (ESR)
[x] by sex colours (ESR)
[x] check at risk data availability (ESR)
[x] ESR over time should show all people when by sex data not present even if deactivated
[x] add and fix chart source

Metric overlay, on Country pages (#107, #114)

[x] Close when metric clicked again (unselected)
[x] Dimension overlay button covers definition
[x] Accordion dropdowns for: metric info and data sources
[x] Highlight metric/bar when clicked/selected?
[x] should also open on bar click

Country at risk tab

[x] highlight at risk group for country after navigation

Metric overview

[x] Add metric name to tab bar // don't show tab name when only one tab

Single metric view

[x] add intro texts
[x] Close country overlay when country clicked again (un-selected)
[x] drop income-adjusted benchmark for global best setting (ESR)
[x] add illustrations
[x] highlight country/bar when clicked/selected
[x] country panel should open when clicking anywhere on bar
[x] style related metrics links
[x] source not visible when hi note present

People overview

[x] add intro texts
[x] add background colour
[x] tiles should have same height when in same row

Single people

[x] add intro texts
[x] add background colour
[x] consider need for title

Pages

[x] style links
[x] style section dividers
[x] hierarchy/headers
[x] style close

Settings panel (#107, #114 )

[x] close on tab change
[x] close on scroll out of view (or consider updating)
[x] close on Right overlay (single country pages)
[x] close on Country overlay (single metric pages)
[x] remove "scale" text and explanations
[x] include intro paragraph for settings panel
[x] include key with ESR settings

How to read overlay

[x] change title to include the chart name
[x] CPR bars missing uncertainty band
[x] need CPR bars w/out uncertainty band for country snapshot charts

Charts

[x] ESR re-add grey background when not showing grades (ie country overview & single metric views)
[x] row labels should not be links if no onClick handler provide (by sex chart)
[x] show scores on far end of bars
[x] offer Settings and HTR tools for each chart
[x] consider fixing chart header to top of view when scrolling
[x] consider adding note to explain HI (or move it into How to Read?)
[x] "no data" labels not aligned
[x] change benchmark tooltip
[x] benchmark tooltip text should best highlight the current selected one, especially when removing the label
[x] remove background from trend chart,
[ ] include benchmark label in trend chart
[ ] consider small key for uncertainty bars below chart

Metric/country overlays/aside panels

[x] style FAQ background (esp inverse colours)
[x] style "more link" (inverse colours)
[x] style text links (inverse)

Interaction

[x] aside overlays should close on header interaction
[x] sty;e tooltip
[ ] include scroll to top in floating tab navigation (what about country overview where we do not have the tab bar???)

Data

[x] Check ESR income-adjusted benchmark. Sorting by GDP does not correlate well with income-benchmark, also very few countries at any income level reach 100% (who are the benchmark countries?). Does not resemble the "achievement possibility frontier"

Code general

[x] check need for useInjectSaga
[x] cleanup translations
[ ] cleanup prepareData routines

Styles general

[x] header methodology links
[x] style tooltips (bg colour)
[ ] Extend maximum content width to 1440px

tmfrnz commented 4 years ago

@annemariebrook today Edith and I adjusted or added the background colours on the home page and overview pages. In particular we suggest:

a light red/salmon for the "Data cards" section on the home page
a light orange for the "People" section on the home page, as well as for the People overview page
a light purple for the "About" section on the home page, as well as for the Country overview page

annemariebrook commented 4 years ago

The colours look great! Thanks so much Timo and Edith.

One final design change we'd like to request is the big purple diamond on the landing page photos. We've had a lot of feedback from people who find it quite annoying - and I agree as it gets in the way of the photos a bit. I'd like to ask Adina to review it once she's back on board, but in the meantime our intern Abigail suggested that we just move it up to the top left corner of the photo, so it kind of looks like it's pinning the photo. I was going to ask you about this on our call tonight but mentioning it here now in case you'd like to consult with Edith.

We'd also like to delete the landing page photo of the boy whose head is quite a lot lower than the other heads, as this photo is inconsistent with the others. Can you please remove this one? Thank you!

tmfrnz commented 4 years ago

The colours look great! Thanks so much Timo and Edith.

One final design change we'd like to request is the big purple diamond on the landing page photos. We've had a lot of feedback from people who find it quite annoying - and I agree as it gets in the way of the photos a bit. I'd like to ask Adina to review it once she's back on board, but in the meantime our intern Abigail suggested that we just move it up to the top left corner of the photo, so it kind of looks like it's pinning the photo. I was going to ask you about this on our call tonight but mentioning it here now in case you'd like to consult with Edith.

We agree and suggest to move it to the bottom right corner

We'd also like to delete the landing page photo of the boy whose head is quite a lot lower than the other heads, as this photo is inconsistent with the others. Can you please remove this one? Thank you!

Have removed

tmfrnz commented 4 years ago

[x] Category label too wide

tmfrnz commented 4 years ago

[x] slider button transparency (white) not ideal with coloured background

tmfrnz commented 4 years ago

[x] fixed tab header overlays drop down menu (mobile only)

tmfrnz commented 4 years ago

[x] "On the Safety and Empowerment tabs on the country pages, the "Source" note is very close to the bottom of the charts. If the gap could be increased slightly (to be more like that for Quality of Life), that would be great. But not a major."

tmfrnz commented 4 years ago

moving open tasks as ideas to new issue https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/185

HumanRightsMeasurementInitiative / hrmi-dataportal

v3 miscellaneous TODO #118

Header

[x] search active index should reset on text change

Home

Country overview

Single country

Country snapshot #114

Country details #107

Metric overlay, on Country pages (#107, #114)

Country at risk tab

Metric overview

Single metric view

People overview

Single people

Pages

Settings panel (#107, #114 )

How to read overlay

Charts

Metric/country overlays/aside panels

Interaction

Data

Code general

Styles general