HumanRightsMeasurementInitiative / hrmi-dataportal

https://rightstracker.org
Other
4 stars 8 forks source link

Improve consistency of no-data presentation #125

Closed annemariebrook closed 4 years ago

annemariebrook commented 4 years ago

For countries that have no data there is an inconsistency in the way the CPR and ESR 'no data' are presented. For the ESRs there is an empty graph. For the CPRs we have sentence "Data not yet available". This is the case for both the At a Glance tabs and the detail tabs.

image

Thalia and I have discussed this, and our preferred solution would be to add empty graphs for the CPRs, as that way users can see more detail on what they are missing out on. This also seems more consistent with the presentation of the data for countries where there is e.g. only one ESR score.

The alternative solution would be ok also, if there is some reason why our preferred solution isn't a good idea (i.e. replace the empty ESR graphs with the same sentence we use for the CPRs when no data).

This is not an urgent request. i.e. it isn't vital for 3.0 launch. But it would be nice, for consistency.

tmfrnz commented 4 years ago

Ok this should not be hard.

I guess the reasoning for treating ESR differently here was that the scores may sometimes be available for the different assessment standard.

tmfrnz commented 4 years ago

Have quickly changed this already as this was very quick to do https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/commit/58de3e82a2c9ec81c4801b9a247a3e45a0d3980e

annemariebrook commented 4 years ago

Thanks. Is it also easy to add the empty tables to the two CPR tabs as well? (keeping the text that is there currently).

tmfrnz commented 4 years ago

Yes will do

tmfrnz commented 4 years ago

Added empty tables to CPR tabs