HumanRightsMeasurementInitiative / hrmi-dataportal

https://rightstracker.org
Other
4 stars 8 forks source link

Review "sort by availability" #140

Open tmfrnz opened 4 years ago

tmfrnz commented 4 years ago

When sorting by availability on the all countries page, I was trying to figure out how the algorithm works. The thing that seems weird is that some countries with, say, all five ESRs appear after some countries with only four ESRs. It appears the high-income countries are being 'placed' further ahead. But in some cases the differences are more extreme. e.g. Singapore (with only 2 ESRs) appears before several countries with four ESRs (including some high income countries with four ESRs). This isn't a big deal but does seem a little odd. I think it would be better just to have them ordered first by the number of bars that show up in the 13 rights view (and then sorted by name within each group). I think their income group should be irrelevant here.

tmfrnz commented 4 years ago

The algorithm looks after all available rights scores regardless of income level. This was done so that the order of countries does not change when changing the settings (ie assessment standard) which could otherwise be confusing. This was probably more relevant with the v2 settings panel (at bottom).

annemariebrook commented 4 years ago

Ah - ok - i get it now. So it takes into account the number of rights scores available on BOTH assessment standards, even though only one is visible at a time. Thanks for explaining. I think it would be ideal if it reordered according to the settings, but i can see why this wasn't originally done. Happy to leave it as is for now :-)

tmfrnz commented 4 years ago

Great, regardless this should not be too hard to change in the future