[WIP] time-chart presentation tweaks

HumanRightsMeasurementInitiative / hrmi-dataportal

https://rightstracker.org

Other

4 stars 8 forks source link

[WIP] time-chart presentation tweaks #174

Closed iainkirkpatrick closed 4 years ago

iainkirkpatrick commented 4 years ago

Addresses #170

TODO:

[x] fix display of time-trend QOL charts on Firefox
[x] CPR charts narrower as per issue
[x] confidence band displayed, show upper and lower figures on hover (?)

Closes #170

iainkirkpatrick commented 4 years ago

@tmfrnz are you interested in reviewing PR's in this pre-launch period? No worries if not - I'm happy to manage it, just checking in :)

tmfrnz commented 4 years ago

Again, I think we could still improve the chart width (padding inside or outside) but given the approaching release, I am happy to merge this as this effectively fixes the FF issue

annemariebrook commented 4 years ago

@iainkirkpatrick - Thanks very much for your work on this. I agree with @tmfrnz that the charts are better with padding so that the dates don't sit on the extremes, especially at the y-axis end of the charts. This is especially important for the CPR charts, as the time series are so short, this helps to communicate the fact that there isn't any earlier data. I also agree that it is would be better to give the ESR charts the full width - but they are OK as is (except for the padding issue).

iainkirkpatrick commented 4 years ago

Just read these comments team - agree, I can try to action this as a smaller tweak along with the other design tweaks we are implementing over the next couple of days. 👍