search

HumanRightsMeasurementInitiative / hrmi-dataportal

https://rightstracker.org
Other
4 stars 8 forks source link

Feature/pdf puppeteer #198

Closed bsides44 closed 3 years ago

bsides44 commented 4 years ago

Styled pdf page lengths Fixed pdf url params

Closes #61

iainkirkpatrick commented 4 years ago

Update: after learning from Timo that the server code isn't actually used in production, I have implemented a Firebase Function to handle the pdf request from the client. This is running in local development and in 'production' (currently a separate deployment for this branch of work, see https://hrmi-dataportal-pdf.web.app).

For local development, devs should run the npm script serve inside the functions folder (which has a separate package.json as per Firebase conventions). That will emulate the functions locally, and I have configured webpack to insert the right env var to point to the local emulated functions endpoint in local dev (and the production endpoint for prod). That prod endpoint will need to be manually adjusted once this branch is merged into master.

FYI @bsides44

iainkirkpatrick commented 3 years ago

Closing as this has been superseeded by current work.