search

HumanRightsMeasurementInitiative / hrmi-dataportal

https://rightstracker.org
Other
4 stars 8 forks source link

Metric tab labels very long #80

Closed tmfrnz closed 4 years ago

tmfrnz commented 4 years ago

Metric tab labels very long (ES only)

Not breaking the layout but not pretty

image

@Catherine104 also one for you to check - thanks! @tmfrnz can they all be like the 'Opinion y expresion'? Seems like they have the same number of words but able to fit in 1 line. I think it's fine if they break into 2 lines due to no space.

Originally posted by @tmfrnz in https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/73#issuecomment-534116078

tmfrnz commented 4 years ago

Will try and improve layout

annemariebrook commented 4 years ago

Hi @tmfrnz. I've taken a look at this, but I don't have any good suggestions for fixing this, sorry. I presume this is only a problem on smaller screens? (it looks fine on my desktop). Thank you for doing what you can to improve layout. But if it's not perfect, let's not worry about it too much.

tmfrnz commented 4 years ago

Also too long for modal & mobile screens (also not critical) image

tmfrnz commented 4 years ago

Here is another example from the overview page where the metrics tab label gets too long (ES and PT) image

@sarahbichan may be something for you to look at?

sarahbichan commented 4 years ago

I've added this to my task tracker.

Thanks.

Sarah

On Mon, Dec 16, 2019 at 4:28 AM Timo Franz notifications@github.com wrote:

Here is another example from the overview page where the metrics tab label gets too long (ES and PT) [image: image] https://user-images.githubusercontent.com/5811956/70864926-dbe42800-1f57-11ea-9162-f0569ffe8725.png

@sarahbichan https://github.com/sarahbichan may be something for you to look at?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/80?email_source=notifications&email_token=AN2LQVCX3AWEU7W5MW2XOIDQYZEKVA5CNFSM4I3GDF42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG43QQI#issuecomment-565819457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LQVCKT7ABSFMMZEOBECTQYZEKVANCNFSM4I3GDF4Q .

-- Sarah Bichan

Throw your dreams into space like a kite, and you do not know what it will bring back: a new life, a new friend, a new love, a new country - Anais Nin

tmfrnz commented 4 years ago

@sarahbichan i do not think we will need to worry about this any more as the layout is about to change