Closed tmfrnz closed 4 years ago
@Catherine104 a few more missing translations for you to enter (in addition to #76)
From @Catherine104's comment on #12
@tmfrnz we already have the cookie message for French, Portuguese and Spanish. Can you please update them? Please let me know if you'd like me to do that instead. French: Nous souhaitons conserver les cookies et les données d'utilisation afin d'améliorer votre expérience. [Je suis d'accord] [Non merci] Pour toutes les fonctions du site, il est nécessaire de collecter un nombre réduit de données utilisateur, ce que vous acceptez en poursuivant votre navigation de ce site. Pour en savoir plus, veuillez lire notre politique de confidentialité
Spanish Nos gustaría almacenar cookies y datos de uso para mejorar su experiencia. [Estoy de acuerdo] [No, gracias] Para que un sitio web funcione, es necesario recopilar una pequeña cantidad de datos de usuario, por lo que, si continúa utilizando este sitio web, estará dando su consentimiento para ello. Para más información, consulte nuestra política de privacidad.
Portuguese Gostaríamos de armazenar cookies e dados de utilização para melhorar a sua experiência. [Por mim tudo bem] [Não, obrigado] Para que qualquer site funcione, é necessário recolher uma pequena quantidade de dados do utilizador. Ao continuar a usar este site, estará a dar o seu consentimento. Para saber mais, por favor leia a nossa política de privacidade.
Thank you
Hi Timo, CC and I have just been looking at this issue, and we think it is all complete. Can we move it to done?
@annemariebrook I do not think that all of the fields (specified above) have been translated, ie https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/blob/master/app/translations/pt.json#L76
It would be great, if you could check any completed fields so we can keep track of what has been done (another good practice is to reference the issue in the change message when committing any changes (i.e. #83
) - this way an entry will be made here in the issue conversation
@sarahbichan may this is also something for you too look at. See the initial description for the missing fields
Ok. Thanks.
On Mon, Dec 16, 2019 at 4:32 AM Timo Franz notifications@github.com wrote:
@sarahbichan https://github.com/sarahbichan may this is also something for you too look at. See the initial description for the missing fields
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/83?email_source=notifications&email_token=AN2LQVHCSMHEXZUJEP4D4FDQYZEZHA5CNFSM4I34CFGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG43TMA#issuecomment-565819824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LQVAEPXPXX7I33HAHPKDQYZEZHANCNFSM4I34CFGA .
-- Sarah Bichan
Throw your dreams into space like a kite, and you do not know what it will bring back: a new life, a new friend, a new love, a new country - Anais Nin
Field 76 in PT and field 75 in ES now translated and updated.
Great - have just updated the site accordingly.
A few notes
hrmi.containers.HowToRead.simpleBar.drilldownHint
)Of course, it makes a lot more sense to use field names! Sorry.
I was too quick to say that the issue had been resolved. Remedying this now. I'll check the boxes once it's done.
On Fri, Jan 17, 2020 at 1:05 AM Timo Franz notifications@github.com wrote:
Great - have just updated the site accordingly.
A few notes
- there are still several fields not translated (see above, #83 (comment) https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/83#issue-500331690 )
- line numbers may change, so it is preferable to refer to the fields to their id instead (eg hrmi.containers.HowToRead.simpleBar.drilldownHint)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/issues/83?email_source=notifications&email_token=AN2LQVHY5MVGU6RNQTVLP3DQ6BEQXA5CNFSM4I34CFGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJD2WHI#issuecomment-575122205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LQVGQNQMOBKWN3T4JDMTQ6BEQXANCNFSM4I34CFGA .
-- Sarah Bichan
Throw your dreams into space like a kite, and you do not know what it will bring back: a new life, a new friend, a new love, a new country - Anais Nin
Looking good!
https://github.com/HumanRightsMeasurementInitiative/hrmi-dataportal/blob/master/app/translations
How to read
Cookie consent (ES, PT, FR) (related to #12, #43)